Add system test for 'Sink.create' using a Pubsub topic. by tseaver · Pull Request #1656 · googleapis/google-cloud-python

tseaver · 2016-03-24T18:12:16Z

Currently broken because 'Topic.set_iam_policy' returns 503s. See: #1654.

Sign in to view

+ try:
+ doomed.delete()
+ except NotFound as error:
+ print('Unable to delete resource: %s' % error)


Convert names from the XML API to the equivalent JSON names. Fixes#1659.

tseaver · 2016-03-28T17:16:40Z

Rebased after merging #1658 to the logging-api branch.

…n_spellings Allow predefined ACL names from either XML or JSON APIs.

fix failing tests remove typing from expected value remove schema marker from dns#quotas return value update test specs for dns.Client#quotas remove schema marker from dns#quotas return value update test specs for dns.Client#quotas remove schema marker from dns#quotas return value fix failing tests for dns#quotas return value conditional skipping of the `kind` key

…o ojengwa-master

Fixes#1673.

Improve correspondence w/ role names used by pubsub. Addresses: #1654 (comment)#1654 (comment).

Addresses: #1654 (comment)#1654 (comment)

Addresses: #1654 (comment)#1654 (comment).

Address three separate cases: - Query finishes within timeout, with all rows present. - Query finishes within timeout, but result set is too large for initial response. - Query times out. Closes#1551.

Expand/clarify synchronous query usage docs.

Add system tests for topic/subscription IAM policy get/set methods.

Cache job constructed for a synchronous query.

tseaver · 2016-03-30T16:17:17Z

@dhermes 1248b66 backs out the workaround for #1657. PTAL

Sign in to view

 self.to_delete = []

 def tearDown(self):
+ from gcloud.exceptions import NotFound


Broken because 'Topic.set_iam_policy' returns 503s. See: #1654.

Addresses: #1656 (comment)#1656 (comment)

Addresses: #1656 (comment)

googlebot · 2016-03-30T16:59:09Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

dhermes · 2016-03-30T16:59:44Z

Bad rebase?

dhermes · 2016-03-30T17:00:56Z

Continuing our discussion. Yeah it is too clever but a few more lines will get you where you need without having a hardcoded URL in two different places.

url=pubsub_client.connection.api_base_url+topic.pathifurl.startswith('https://'):
url=url[8:]

tseaver · 2016-03-30T17:01:08Z

Yup, I hadn't pushed the underlying logging-api merge yet (needed to make topic.setIamPolcy not raise).

dhermes · 2016-03-30T17:01:45Z

Ping me when this PR looks how you expected it to?

tseaver · 2016-03-30T17:02:38Z

Using pubsub_client.connection.api_base_url to compute the prefix of the destination string is wrong: the prefix as defined in the projects.sink.create API just happens to match. I've updated to use topic.full_name to compute the suffix, however.

tseaver · 2016-03-30T17:04:14Z

Sigh. I'll open a new PR.

…transport (#1656) * feat: support snippet generation for services that only support REST transport * formatting

tseaver added testing do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: logging Issues related to the Cloud Logging API. labels Mar 24, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 24, 2016

tseaver changed the title ~~Add system test for sink creation w/ pubsub topic.~~Add system test for 'Sink.create' using a Pubsub topic.Mar 24, 2016

dhermes reviewed Mar 28, 2016
View reviewed changes

Comment threadsystem_tests/logging_.py Outdated
try:
doomed.delete()
except NotFound as error:
print('Unable to delete resource: %s' % error)
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

Allow predefined ACL names from either XML or JSON APIs.
f8f153d
Convert names from the XML API to the equivalent JSON names. Fixes#1659.

tseaverand others added 14 commits March 28, 2016 13:52

Merge pull request#1664from tseaver/1659-predefined_acl-support_jso…
4ccb7a1
…n_spellings Allow predefined ACL names from either XML or JSON APIs.

Merge branch 'master' ofhttps://github.com/ojengwa/gcloud-pythonint…
a1acc15
…o ojengwa-master

Add a unit test which actually exercises#1650.
247e293

Merge branch 'ojengwa-master'
f29d0bc

Add system tests for topic/subscription IAM policy get/set methods.
21cfae6

Cache job constructed for a synchronous query.
b53fec5
Fixes#1673.

Rename 'readers'->'viewers', 'writers'->'editors'.
e770e9e
Improve correspondence w/ role names used by pubsub. Addresses: #1654 (comment)#1654 (comment).

Use role-name constants.
da06d10
Addresses: #1654 (comment)#1654 (comment)

Assert created topic/subscription exists before use.
0116b18
Addresses: #1654 (comment)#1654 (comment).

Expand/clarify synchronous query usage docs.
9ed6997
Address three separate cases: - Query finishes within timeout, with all rows present. - Query finishes within timeout, but result set is too large for initial response. - Query times out. Closes#1551.

Merge pull request#1674from tseaver/1551-bigquery-job_query_status
f4b8e1c
Expand/clarify synchronous query usage docs.

Merge pull request#1654from tseaver/pubsub-system_tests-iam_policy
7aafecd
Add system tests for topic/subscription IAM policy get/set methods.

Merge pull request#1675from tseaver/1673-bigquery-reify_query_job
b8eac84
Cache job constructed for a synchronous query.

tseaver assigned tseaver and dhermes and unassigned tseaver Mar 30, 2016

dhermes reviewed Mar 30, 2016
View reviewed changes

Comment threadsystem_tests/logging_.py Outdated
self.to_delete = []

def tearDown(self):
from gcloud.exceptions import NotFound
This comment was marked as spam.
Sign in to view

tseaver added 2 commits March 30, 2016 12:50

Merge branch 'master' into logging-api
81be985

Add system test for sink creation w/ pubsub topic.
0afb7b5
Broken because 'Topic.set_iam_policy' returns 503s. See: #1654.

tseaver added 2 commits March 30, 2016 12:51

Back out swallowing/loggin teardown failures due to#1657.
fb0f813
Addresses: #1656 (comment)#1656 (comment)

Use 'topic.full_name' to compute destination URI.
8ca22dc
Addresses: #1656 (comment)

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 30, 2016

tseaver closed this Mar 30, 2016

tseaver mentioned this pull request Mar 30, 2016
Add system test for 'Sink.create' using a Pubsub topic #1680
Merged

theacodes unassigned dhermes Sep 28, 2018

parthea pushed a commit that referenced this pull request Nov 24, 2025
feat: support snippet generation for services that only support REST …
5844425
…transport (#1656) * feat: support snippet generation for services that only support REST transport * formatting

parthea pushed a commit that referenced this pull request Apr 1, 2026
perf: Fold row count ops when known (#1656)
ed384d9

Navigation Menu

Uh oh!

Add system test for 'Sink.create' using a Pubsub topic. - #1656

Add system test for 'Sink.create' using a Pubsub topic.#1656
tseaver wants to merge 19 commits into
googleapis:logging-apifrom
tseaver:logging-system_tests-sink_create_pubsub_topic

tseaver commented Mar 24, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Mar 28, 2016

Uh oh!

tseaver commented Mar 30, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

googlebot commented Mar 30, 2016

Uh oh!

dhermes commented Mar 30, 2016

Uh oh!

dhermes commented Mar 30, 2016

Uh oh!

tseaver commented Mar 30, 2016

Uh oh!

dhermes commented Mar 30, 2016

Uh oh!

tseaver commented Mar 30, 2016

Uh oh!

tseaver commented Mar 30, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

tseaver commented Mar 24, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Mar 28, 2016

Uh oh!

tseaver commented Mar 30, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

googlebot commented Mar 30, 2016

Uh oh!

dhermes commented Mar 30, 2016

Uh oh!

dhermes commented Mar 30, 2016

Uh oh!

tseaver commented Mar 30, 2016

Uh oh!

dhermes commented Mar 30, 2016

Uh oh!

tseaver commented Mar 30, 2016

Uh oh!

tseaver commented Mar 30, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants