Skip to content

Support entry labels - #1668

Merged
tseaver merged 7 commits into
googleapis:logging-apifrom
tseaver:logging-support_entry_labels
Mar 28, 2016
Merged

Support entry labels#1668
tseaver merged 7 commits into
googleapis:logging-apifrom
tseaver:logging-support_entry_labels

Conversation

@tseaver

@tseavertseaver commented Mar 28, 2016

Copy link
Copy Markdown
Contributor

Fetched entries expose labels set on the back-end.

When logging, labels can be passed in explicitly to the log_text, log_struct, or log_proto methods. If not passed, any default values configured on the logger instance will be used.

See: #1566.

@tseavertseaver added the api: logging Issues related to the Cloud Logging API. label Mar 28, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2016
@tseaver
Track labels set on an entry by the backend.
dfd815a
@tseaver
Allow setting default labels on a logger instance.
2c4c5b3
@tseaver
Add support for logging entries with labels.
64e2f1c
Labels can be passed in explicitly to the 'log_text', 'log_struct', or
'log_proto' methods. If not passed, any default values configured on
the logger instance will be used.
See: #1566.
dhermes
dhermes reviewed Mar 28, 2016
View reviewed changes
Comment threadgcloud/logging/logger.py Outdated

labels = self._get_labels(labels)
if labels is not None:
data['entries'][0]['labels'] = labels

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes
dhermes reviewed Mar 28, 2016
View reviewed changes
Comment threadgcloud/logging/logger.py
return Batch(self, client)

def log_text(self, text, client=None):
def _make_entry_resource(self, text=None, info=None, message=None,

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes

dhermes commented Mar 28, 2016

Copy link
Copy Markdown
Contributor

LGTM. 7 commits seems like a lot?

@tseaver

tseaver commented Mar 28, 2016

Copy link
Copy Markdown
ContributorAuthor

7 commits seems like a lot?

Two of the commits are bugfixes for already-merged-to-logging-api code. :(

@dhermes

dhermes commented Mar 28, 2016

Copy link
Copy Markdown
Contributor

You can do with the commits as you see fit. You are go to merge on my end.

@tseaver
tseaver merged commit f1b9261 into googleapis:logging-apiMar 28, 2016
@tseaver
tseaver deleted the logging-support_entry_labels branch March 28, 2016 19:41
@tseaver

tseaver commented Mar 28, 2016

Copy link
Copy Markdown
ContributorAuthor

I merged as-is after aborting a rebase where I tried to clean it up.

@tseavertseaver mentioned this pull request Mar 30, 2016
Closed
@dhermesdhermes mentioned this pull request Apr 1, 2016
Merged
parthea pushed a commit that referenced this pull request Nov 24, 2025
@dizcology
fix: mock return_value should not populate oneof message fields (#1668)
1d28775
* fix: mock return_value should not populate oneof message fields
parthea pushed a commit that referenced this pull request Mar 9, 2026
@chandra-siri
chore: skip failing samples due to public access prevention enforceme…
b2b4f79
…nt (#1668)
skip failing samples due to public access prevention enforcement. More Details on b/469643064
parthea pushed a commit that referenced this pull request Apr 1, 2026
@Genesis929
feat: DataFrames.__getitem__ support for slice input (#1668)
2eba6fa
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: loggingIssues related to the Cloud Logging API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver@dhermes@googlebot