fix(geminidataanalytics)!: generate and default to v1 by noahdietz · Pull Request #17007 · googleapis/google-cloud-python

noahdietz · 2026-05-08T17:06:27Z

Adds v1 to existing google-cloud-geminidataanalytics client and switches default_version to v1.

Towards b/510217868

snippet-bot · 2026-05-08T17:06:43Z

Here is the summary of changes.

You are about to add 34 region tags.

packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_agent_service_create_data_agent_async.py:26, tag geminidataanalytics_v1_generated_DataAgentService_CreateDataAgent_async
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_agent_service_create_data_agent_sync.py:26, tag geminidataanalytics_v1_generated_DataAgentService_CreateDataAgent_sync
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_agent_service_create_data_agent_sync_async.py:26, tag geminidataanalytics_v1_generated_DataAgentService_CreateDataAgentSync_async
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_agent_service_create_data_agent_sync_sync.py:26, tag geminidataanalytics_v1_generated_DataAgentService_CreateDataAgentSync_sync
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_agent_service_delete_data_agent_async.py:26, tag geminidataanalytics_v1_generated_DataAgentService_DeleteDataAgent_async
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_agent_service_delete_data_agent_sync.py:26, tag geminidataanalytics_v1_generated_DataAgentService_DeleteDataAgent_sync
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_agent_service_delete_data_agent_sync_async.py:26, tag geminidataanalytics_v1_generated_DataAgentService_DeleteDataAgentSync_async
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_agent_service_delete_data_agent_sync_sync.py:26, tag geminidataanalytics_v1_generated_DataAgentService_DeleteDataAgentSync_sync
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_agent_service_get_data_agent_async.py:26, tag geminidataanalytics_v1_generated_DataAgentService_GetDataAgent_async
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_agent_service_get_data_agent_sync.py:26, tag geminidataanalytics_v1_generated_DataAgentService_GetDataAgent_sync
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_agent_service_get_iam_policy_async.py:26, tag geminidataanalytics_v1_generated_DataAgentService_GetIamPolicy_async
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_agent_service_get_iam_policy_sync.py:26, tag geminidataanalytics_v1_generated_DataAgentService_GetIamPolicy_sync
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_agent_service_list_accessible_data_agents_async.py:26, tag geminidataanalytics_v1_generated_DataAgentService_ListAccessibleDataAgents_async
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_agent_service_list_accessible_data_agents_sync.py:26, tag geminidataanalytics_v1_generated_DataAgentService_ListAccessibleDataAgents_sync
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_agent_service_list_data_agents_async.py:26, tag geminidataanalytics_v1_generated_DataAgentService_ListDataAgents_async
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_agent_service_list_data_agents_sync.py:26, tag geminidataanalytics_v1_generated_DataAgentService_ListDataAgents_sync
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_agent_service_set_iam_policy_async.py:26, tag geminidataanalytics_v1_generated_DataAgentService_SetIamPolicy_async
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_agent_service_set_iam_policy_sync.py:26, tag geminidataanalytics_v1_generated_DataAgentService_SetIamPolicy_sync
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_agent_service_update_data_agent_async.py:26, tag geminidataanalytics_v1_generated_DataAgentService_UpdateDataAgent_async
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_agent_service_update_data_agent_sync.py:26, tag geminidataanalytics_v1_generated_DataAgentService_UpdateDataAgent_sync
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_agent_service_update_data_agent_sync_async.py:26, tag geminidataanalytics_v1_generated_DataAgentService_UpdateDataAgentSync_async
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_agent_service_update_data_agent_sync_sync.py:26, tag geminidataanalytics_v1_generated_DataAgentService_UpdateDataAgentSync_sync
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_chat_service_chat_async.py:26, tag geminidataanalytics_v1_generated_DataChatService_Chat_async
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_chat_service_chat_sync.py:26, tag geminidataanalytics_v1_generated_DataChatService_Chat_sync
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_chat_service_create_conversation_async.py:26, tag geminidataanalytics_v1_generated_DataChatService_CreateConversation_async
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_chat_service_create_conversation_sync.py:26, tag geminidataanalytics_v1_generated_DataChatService_CreateConversation_sync
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_chat_service_delete_conversation_async.py:26, tag geminidataanalytics_v1_generated_DataChatService_DeleteConversation_async
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_chat_service_delete_conversation_sync.py:26, tag geminidataanalytics_v1_generated_DataChatService_DeleteConversation_sync
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_chat_service_get_conversation_async.py:26, tag geminidataanalytics_v1_generated_DataChatService_GetConversation_async
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_chat_service_get_conversation_sync.py:26, tag geminidataanalytics_v1_generated_DataChatService_GetConversation_sync
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_chat_service_list_conversations_async.py:26, tag geminidataanalytics_v1_generated_DataChatService_ListConversations_async
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_chat_service_list_conversations_sync.py:26, tag geminidataanalytics_v1_generated_DataChatService_ListConversations_sync
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_chat_service_list_messages_async.py:26, tag geminidataanalytics_v1_generated_DataChatService_ListMessages_async
packages/google-cloud-geminidataanalytics/samples/generated_samples/geminidataanalytics_v1_generated_data_chat_service_list_messages_sync.py:26, tag geminidataanalytics_v1_generated_DataChatService_ListMessages_sync

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

gemini-code-assist

Code Review

This pull request promotes the Gemini Data Analytics API client library to v1, replacing v1alpha as the default version. The update encompasses comprehensive changes across library configuration, metadata, and documentation, alongside the complete implementation of v1 services, transports, and types. Feedback from the review identifies several documentation improvements needed in datasource.py, specifically addressing an inconsistency in the BigQueryTableReferences docstring, removing internal proto path references, and fixing a truncated attribute description.

gemini-code-assist · 2026-05-08T17:14:57Z

+ r"""Message representing references to BigQuery tables and property
+ graphs. At least one of ``table_references``,
+ ``property_graph_references``, or ``search_scope`` must be
+ populated.


The docstring for BigQueryTableReferences states that at least one of table_references, property_graph_references, or search_scope must be populated. However, the message definition only includes table_references. Ensure the docstring accurately reflects the implementation, even if other documentation sources (like proto files) are inconsistent.
References
Ensure docstrings reflect logic correctly, even if other documentation sources (like proto files) are inconsistent.

gemini-code-assist · 2026-05-08T17:14:57Z

+ Optional. Table display_name (same as label in
+ cloud/data_analytics/anarres/data/looker/proto/model_explore.proto),
+ not required, currently only Looker has this field.


The docstring for display_name in the Schema message contains a reference to an internal Google proto path (cloud/data_analytics/anarres/data/looker/proto/model_explore.proto). This internal detail should be removed from the public API documentation to maintain clarity and professionalism.
Suggested change
Optional. Tabledisplay_name (sameaslabelin
cloud/data_analytics/anarres/data/looker/proto/model_explore.proto),
notrequired, currentlyonlyLookerhasthisfield.
Optional. Tabledisplay_name, notrequired, currentlyonlyLookerhasthisfield.

gemini-code-assist · 2026-05-08T17:14:57Z

+ sources.
+ display_name (str):
+ Optional. Field display_name (same as label in
+ subfields (MutableSequence[google.cloud.geminidataanalytics_v1.types.Field]):


The docstring for the display_name attribute in the Field message is truncated and ends abruptly. It should be completed to provide full context to the user.

daniel-sanche · 2026-05-08T17:52:50Z

I added a ! to the title, since I believe this should be a breaking change. I'm going to come back and look at this soon to be sure though

daniel-sanche · 2026-05-08T21:29:26Z

Removed !, because this library is in previous, so we can update the default without a major update

daniel-sanche

LGTM

Adds `v1` to existing `google-cloud-geminidataanalytics` client and switches `default_version` to `v1`. Towards b/510217868

feat(geminidataanalytics): generate and default to v1
8f1f42f

noahdietz requested review from a team as code owners May 8, 2026 17:06

gemini-code-assistBot reviewed May 8, 2026
View reviewed changes

noahdietz assigned daniel-sanche May 8, 2026

daniel-sanche changed the title ~~feat(geminidataanalytics): generate and default to v1~~feat(geminidataanalytics)!: generate and default to v1May 8, 2026

daniel-sanche added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 8, 2026

daniel-sanche removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 8, 2026

daniel-sanche changed the title ~~feat(geminidataanalytics)!: generate and default to v1~~feat(geminidataanalytics): generate and default to v1May 8, 2026

daniel-sanche approved these changes May 8, 2026
View reviewed changes

daniel-sanche changed the title ~~feat(geminidataanalytics): generate and default to v1~~fix(geminidataanalytics)!: generate and default to v1May 8, 2026

parthea merged commit 3820d9d into googleapis:mainMay 11, 2026
32 checks passed

noahdietz deleted the onboard-new-library-2026-05-08 branch May 11, 2026 18:39

nidhiii-27 pushed a commit that referenced this pull request May 18, 2026
fix(geminidataanalytics)!: generate and default to v1 (#17007)
02a73c0
Adds `v1` to existing `google-cloud-geminidataanalytics` client and switches `default_version` to `v1`. Towards b/510217868

Navigation Menu

Uh oh!

fix(geminidataanalytics)!: generate and default to v1 - #17007

fix(geminidataanalytics)!: generate and default to v1#17007
parthea merged 1 commit into
googleapis:mainfrom
noahdietz:onboard-new-library-2026-05-08

noahdietz commented May 8, 2026

Uh oh!

snippet-botBot commented May 8, 2026

Uh oh!

gemini-code-assistBot left a comment

Uh oh!

gemini-code-assistBotMay 8, 2026

Uh oh!

gemini-code-assistBotMay 8, 2026

Uh oh!

gemini-code-assistBotMay 8, 2026

Uh oh!

daniel-sanche commented May 8, 2026

Uh oh!

daniel-sanche commented May 8, 2026

Uh oh!

daniel-sanche left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-Optional. Tabledisplay_name (sameaslabelin
-cloud/data_analytics/anarres/data/looker/proto/model_explore.proto),
-notrequired, currentlyonlyLookerhasthisfield.
+Optional. Tabledisplay_name, notrequired, currentlyonlyLookerhasthisfield.

Uh oh!

Conversation

noahdietz commented May 8, 2026

Uh oh!

snippet-botBot commented May 8, 2026

Uh oh!

gemini-code-assistBot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assistBotMay 8, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assistBotMay 8, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assistBotMay 8, 2026

Choose a reason for hiding this comment

Uh oh!

daniel-sanche commented May 8, 2026

Uh oh!

daniel-sanche commented May 8, 2026

Uh oh!

daniel-sanche left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants