Uh oh!
There was an error while loading. Please reload this page.
Omit 'schema' as part of 'Table.{create,update}' when 'view_query` is set - #1703
Merged
tseaver merged 3 commits intoApr 8, 2016
Merged
Omit 'schema' as part of 'Table.{create,update}' when 'view_query` is set#1703tseaver merged 3 commits into
tseaver merged 3 commits into
Conversation
| if self.view_query is not None: | ||
| view = resource['view'] = {} | ||
| view['query'] = self.view_query | ||
| # https://github.com/GoogleCloudPlatform/gcloud-python/issues/1701 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
dhermes
commented
Apr 7, 2016
Contributor
Lint errors: |
| view = resource['view'] = {} | ||
| view['query'] = self.view_query | ||
| # Back-end rejects 'schema' when passing a query. | ||
| del resource['schema'] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
tseaver
commented
Apr 8, 2016
ContributorAuthor
@dhermes Any remaining issue? |
dhermes
commented
Apr 8, 2016
Contributor
LGTM. Squash if you have the energy for it. |
tseaver added a commit
that referenced
this pull request
Apr 11, 2016
Fix coverage gap introduced in PR #1703.
parthea pushed a commit
that referenced
this pull request
Nov 26, 2025
parthea pushed a commit
that referenced
this pull request
Mar 6, 2026
* fix: load_table_from_dataframe for higher scale decimal * Update test_client.py * fix test_load_table_from_dataframe_w_higher_scale_decimal128_datatype --------- Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
parthea added a commit
that referenced
this pull request
Mar 9, 2026
Bump the current version in `.librarian/state.yaml` to `3.7.0` to cater for googleapis/python-storage#1621 which was released on December 9 2025. This will address the issue in googleapis/python-storage#1701 where librarian sets the version to `3.7.0` which has already been released. The reason that this manual PR is needed is because the release on December 9th used a different tool `release-please` which does not update the `.librarian/state.yaml` file.
parthea pushed a commit
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#1701.