Skip to content

fix: allow multi-part dataset IDs to support BigLake tables - #17137

Merged
shuoweil merged 6 commits into
mainfrom
b512823729-bq-string-references
May 14, 2026
Merged

fix: allow multi-part dataset IDs to support BigLake tables#17137
shuoweil merged 6 commits into
mainfrom
b512823729-bq-string-references

Conversation

@tswast

@tswasttswast commented May 14, 2026

Copy link
Copy Markdown
Contributor

Relaxes DatasetReference.from_string and TableReference.from_string validation.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/512823729 🦕

@tswast
fix: allow multi-part dataset IDs to support BigLake tables
6198e84
Relaxes DatasetReference.from_string and TableReference.from_string
validation.
gemini-code-assist[bot]
gemini-code-assistBot reviewed May 14, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new internal module _string_references.py to centralize the parsing of dataset and table ID strings into REST resource representations, refactoring DatasetReference.from_string and TableReference.from_string to use these shared utilities. Feedback focuses on ensuring Python version compatibility for type unions, correcting PEP 8 indentation violations, programmatically sorting returned dictionaries per repository rules, and refining the logic for multi-part dataset IDs.

Comment threadpackages/google-cloud-bigquery/google/cloud/bigquery/_string_references.py Outdated
Comment threadpackages/google-cloud-bigquery/google/cloud/bigquery/_string_references.py Outdated
Comment threadpackages/google-cloud-bigquery/google/cloud/bigquery/_string_references.py Outdated
Comment threadpackages/google-cloud-bigquery/google/cloud/bigquery/_string_references.py Outdated
@tswast
tswast marked this pull request as ready for review May 14, 2026 19:12
@tswast
tswast requested review from a team as code ownersMay 14, 2026 19:12
@tswast
tswast requested review from shuoweil and removed request for a teamMay 14, 2026 19:12
@shuoweil
shuoweil merged commit f93911c into mainMay 14, 2026
31 checks passed
@shuoweil
shuoweil deleted the b512823729-bq-string-references branch May 14, 2026 21:45
nidhiii-27 pushed a commit that referenced this pull request May 18, 2026
@tswast@nidhiii-27
fix: allow multi-part dataset IDs to support BigLake tables (#17137)
6102c6e
Relaxes DatasetReference.from_string and TableReference.from_string
validation.
Thank you for opening a Pull Request! Before submitting your PR, there
are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a
[bug/issue](https://github.com/googleapis/google-cloud-python/issues)
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
Fixes b/512823729 🦕
This was referenced May 26, 2026
Closed
Closed
@sofislsofisl mentioned this pull request Jun 12, 2026
Merged
sofisl added a commit that referenced this pull request Jun 15, 2026
@sofisl
chore: librarian release pull request: 20260612T171649Z (#17449)
0aff09d
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.
Librarian Version: v0.19.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:234b9d1f2ddb057ed7ac6a38db0bf8163d839c65c6cf88ade52530cddebce59e
<details><summary>google-cloud-bigquery: v3.42.0</summary>
##
[v3.42.0](google-cloud-bigquery-v3.41.0...google-cloud-bigquery-v3.42.0)
(2026-06-12)
### Features
* drop Python 3.7-3.9 support and regenerate (#17187)
([494abcd](494abcdf))
### Bug Fixes
* include pyopenssl as a dependency (#17345)
([1281790](12817900))
* bump requests from 2.21.0 to 2.33.0 in /packages/google-cloud-bigquery
(#17192)
([5283c92](5283c926))
* bump tqdm from 4.23.4 to 4.66.3 in /packages/google-cloud-bigquery
(#17194)
([8cda5fe](8cda5fe1))
* bump opentelemetry-instrumentation from 0.37b0 to 0.41b0 in
/packages/google-cloud-bigquery (#17195)
([f530a2c](f530a2c6))
* allow multi-part dataset IDs to support BigLake tables (#17137)
([f93911c](f93911c0))
### Documentation
* clarify Quickstart POST example (&lt;a
href=&#34;https://redirect.github.com/psf/requests/issues/6960&#34;&gt;#6960&lt;/a&gt;)&lt;/li&gt;
&lt;li&gt;Additional commits viewable in &lt;a
href=&#34;psf/requests@v2.21.0...v2.33.0&#34;&gt;compare
view&lt;/a&gt;&lt;/li&gt; &lt;/ul&gt; &lt;/details&gt; &lt;br /&gt;
([5283c92](5283c926))
* fix FAQ grammar in httplib2 example&lt;/li&gt; &lt;li&gt;&lt;a
href=&#34;psf/requests@774a0b837a194ee885d4fdd9ca947900cc3daf71&#34;&gt;&lt;code&gt;774a0b8&lt;/code&gt;&lt;/a&gt;
([5283c92](5283c926))
* same block as other sections&lt;/li&gt; &lt;li&gt;&lt;a
href=&#34;psf/requests@9c72a41bec8597f948c9d8caa5dc3f12273b3303&#34;&gt;&lt;code&gt;9c72a41&lt;/code&gt;&lt;/a&gt;
Bump github/codeql-action from 4.33.0 to 4.34.1&lt;/li&gt;
&lt;li&gt;&lt;a
href=&#34;psf/requests@ebf71906798ec82f34e07d3168f8b8aecaf8a3be&#34;&gt;&lt;code&gt;ebf7190&lt;/code&gt;&lt;/a&gt;
Bump github/codeql-action from 4.32.0 to 4.33.0&lt;/li&gt;
&lt;li&gt;&lt;a
href=&#34;psf/requests@0e4ae38f0c93d4f92a96c774bd52c069d12a4798&#34;&gt;&lt;code&gt;0e4ae38&lt;/code&gt;&lt;/a&gt;
([5283c92](5283c926))
* exclude Response.is_permanent_redirect from API docs (&lt;a
href=&#34;https://redirect.github.com/psf/requests/issues/7244&#34;&gt;#7244&lt;/a&gt;)&lt;/li&gt;
&lt;li&gt;&lt;a
href=&#34;psf/requests@d568f47278492e630cc990a259047c67991d007a&#34;&gt;&lt;code&gt;d568f47&lt;/code&gt;&lt;/a&gt;
([5283c92](5283c926))
</details>
@chalmerlowechalmerlowe mentioned this pull request Jun 23, 2026
Closed
chalmerlowe pushed a commit that referenced this pull request Jun 25, 2026
@sofisl@chalmerlowe
chore: librarian release pull request: 20260612T171649Z (#17449)
41bcd33
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.
Librarian Version: v0.19.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:234b9d1f2ddb057ed7ac6a38db0bf8163d839c65c6cf88ade52530cddebce59e
<details><summary>google-cloud-bigquery: v3.42.0</summary>
##
[v3.42.0](google-cloud-bigquery-v3.41.0...google-cloud-bigquery-v3.42.0)
(2026-06-12)
### Features
* drop Python 3.7-3.9 support and regenerate (#17187)
([494abcd](494abcdf))
### Bug Fixes
* include pyopenssl as a dependency (#17345)
([1281790](12817900))
* bump requests from 2.21.0 to 2.33.0 in /packages/google-cloud-bigquery
(#17192)
([5283c92](5283c926))
* bump tqdm from 4.23.4 to 4.66.3 in /packages/google-cloud-bigquery
(#17194)
([8cda5fe](8cda5fe1))
* bump opentelemetry-instrumentation from 0.37b0 to 0.41b0 in
/packages/google-cloud-bigquery (#17195)
([f530a2c](f530a2c6))
* allow multi-part dataset IDs to support BigLake tables (#17137)
([f93911c](f93911c0))
### Documentation
* clarify Quickstart POST example (&lt;a
href=&#34;https://redirect.github.com/psf/requests/issues/6960&#34;&gt;#6960&lt;/a&gt;)&lt;/li&gt;
&lt;li&gt;Additional commits viewable in &lt;a
href=&#34;psf/requests@v2.21.0...v2.33.0&#34;&gt;compare
view&lt;/a&gt;&lt;/li&gt; &lt;/ul&gt; &lt;/details&gt; &lt;br /&gt;
([5283c92](5283c926))
* fix FAQ grammar in httplib2 example&lt;/li&gt; &lt;li&gt;&lt;a
href=&#34;psf/requests@774a0b837a194ee885d4fdd9ca947900cc3daf71&#34;&gt;&lt;code&gt;774a0b8&lt;/code&gt;&lt;/a&gt;
([5283c92](5283c926))
* same block as other sections&lt;/li&gt; &lt;li&gt;&lt;a
href=&#34;psf/requests@9c72a41bec8597f948c9d8caa5dc3f12273b3303&#34;&gt;&lt;code&gt;9c72a41&lt;/code&gt;&lt;/a&gt;
Bump github/codeql-action from 4.33.0 to 4.34.1&lt;/li&gt;
&lt;li&gt;&lt;a
href=&#34;psf/requests@ebf71906798ec82f34e07d3168f8b8aecaf8a3be&#34;&gt;&lt;code&gt;ebf7190&lt;/code&gt;&lt;/a&gt;
Bump github/codeql-action from 4.32.0 to 4.33.0&lt;/li&gt;
&lt;li&gt;&lt;a
href=&#34;psf/requests@0e4ae38f0c93d4f92a96c774bd52c069d12a4798&#34;&gt;&lt;code&gt;0e4ae38&lt;/code&gt;&lt;/a&gt;
([5283c92](5283c926))
* exclude Response.is_permanent_redirect from API docs (&lt;a
href=&#34;https://redirect.github.com/psf/requests/issues/7244&#34;&gt;#7244&lt;/a&gt;)&lt;/li&gt;
&lt;li&gt;&lt;a
href=&#34;psf/requests@d568f47278492e630cc990a259047c67991d007a&#34;&gt;&lt;code&gt;d568f47&lt;/code&gt;&lt;/a&gt;
([5283c92](5283c926))
</details>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shuoweilshuoweilshuoweil approved these changes
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tswast@shuoweil