Uh oh!
There was an error while loading. Please reload this page.
chore: update googleapis and regenerate - #17275
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Google Cloud Dataplex, DLP, Gemini Data Analytics, and Network Security client libraries, introducing several new services, requests, and configuration options, alongside regenerated transports and unit tests. Feedback on the changes highlights multiple instances of bare except: blocks in the generated REST transports, which should be updated to catch Exception explicitly and log the error to avoid silently masking potential failures.
| try: | ||
| request_payload = type(request).to_json(request) | ||
| except: | ||
| request_payload = None |
There was a problem hiding this comment.
Avoid using bare except: blocks in Python code. Catching Exception instead of a bare except: prevents intercepting system-level signals like KeyboardInterrupt or SystemExit. Additionally, avoid silently assigning None in broad except Exception: blocks; log the exception using logger.warning to aid in debugging and prevent masking underlying issues.
try:
request_payload=type(request).to_json(request)
exceptExceptionase:
logger.warning(f"Failed to serialize request: {e}")
request_payload=NoneReferences
- Avoid broad except Exception: blocks that silently return None. Instead, log the exception (e.g., using logger.warning) to aid in debugging and prevent masking underlying issues.
| try: | ||
| response_payload = catalog.Entry.to_json(response) | ||
| except: | ||
| response_payload = None |
There was a problem hiding this comment.
Avoid using bare except: blocks in Python code. Catching Exception instead of a bare except: prevents intercepting system-level signals like KeyboardInterrupt or SystemExit. Additionally, avoid silently assigning None in broad except Exception: blocks; log the exception using logger.warning to aid in debugging and prevent masking underlying issues.
try:
response_payload=catalog.Entry.to_json(response)
exceptExceptionase:
logger.warning(f"Failed to serialize response: {e}")
response_payload=NoneReferences
- Avoid broad except Exception: blocks that silently return None. Instead, log the exception (e.g., using logger.warning) to aid in debugging and prevent masking underlying issues.
| try: | ||
| request_payload = type(request).to_json(request) | ||
| except: | ||
| request_payload = None |
There was a problem hiding this comment.
Avoid using bare except: blocks in Python code. Catching Exception instead of a bare except: prevents intercepting system-level signals like KeyboardInterrupt or SystemExit. Additionally, avoid silently assigning None in broad except Exception: blocks; log the exception using logger.warning to aid in debugging and prevent masking underlying issues.
try:
request_payload=type(request).to_json(request)
exceptExceptionase:
logger.warning(f"Failed to serialize request: {e}")
request_payload=NoneReferences
- Avoid broad except Exception: blocks that silently return None. Instead, log the exception (e.g., using logger.warning) to aid in debugging and prevent masking underlying issues.
| try: | ||
| response_payload = ( | ||
| data_products.RequestDataProductAccessResponse.to_json(response) | ||
| ) | ||
| except: | ||
| response_payload = None |
There was a problem hiding this comment.
Avoid using bare except: blocks in Python code. Catching Exception instead of a bare except: prevents intercepting system-level signals like KeyboardInterrupt or SystemExit. Additionally, avoid silently assigning None in broad except Exception: blocks; log the exception using logger.warning to aid in debugging and prevent masking underlying issues.
try:
response_payload= (
data_products.RequestDataProductAccessResponse.to_json(response)
)
exceptExceptionase:
logger.warning(f"Failed to serialize response: {e}")
response_payload=NoneReferences
- Avoid broad except Exception: blocks that silently return None. Instead, log the exception (e.g., using logger.warning) to aid in debugging and prevent masking underlying issues.
| try: | ||
| request_payload = type(request).to_json(request) | ||
| except: | ||
| request_payload = None |
There was a problem hiding this comment.
Avoid using bare except: blocks in Python code. Catching Exception instead of a bare except: prevents intercepting system-level signals like KeyboardInterrupt or SystemExit. Additionally, avoid silently assigning None in broad except Exception: blocks; log the exception using logger.warning to aid in debugging and prevent masking underlying issues.
try:
request_payload=type(request).to_json(request)
exceptExceptionase:
logger.warning(f"Failed to serialize request: {e}")
request_payload=NoneReferences
- Avoid broad except Exception: blocks that silently return None. Instead, log the exception (e.g., using logger.warning) to aid in debugging and prevent masking underlying issues.
| try: | ||
| response_payload = datascans.CancelDataScanJobResponse.to_json( | ||
| response | ||
| ) | ||
| except: | ||
| response_payload = None |
There was a problem hiding this comment.
Avoid using bare except: blocks in Python code. Catching Exception instead of a bare except: prevents intercepting system-level signals like KeyboardInterrupt or SystemExit. Additionally, avoid silently assigning None in broad except Exception: blocks; log the exception using logger.warning to aid in debugging and prevent masking underlying issues.
try:
response_payload=datascans.CancelDataScanJobResponse.to_json(
response
)
exceptExceptionase:
logger.warning(f"Failed to serialize response: {e}")
response_payload=NoneReferences
- Avoid broad except Exception: blocks that silently return None. Instead, log the exception (e.g., using logger.warning) to aid in debugging and prevent masking underlying issues.
suztomo
commented
May 27, 2026
Failed |
suztomo
commented
May 27, 2026
Waiting for a newer version of the generator. |
Update googleapis to the latest commit and regenerate all client libraries.
The changes are generated by:
where V is
v0.15.0.