Uh oh!
There was an error while loading. Please reload this page.
chore(generator): centralize mypy configuration and regenerate google-cloud-datastore POC - #17408
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request consolidates package-specific mypy.ini configurations into a single root mypy.ini file, updates the noxfile.py templates to reference this root configuration, and bumps several dependency versions (such as google-api-core, proto-plus, and protobuf) across the Datastore package. Feedback on the changes highlights that the exclude paths in the new mypy.ini should use (^|/) instead of ^ to ensure they match correctly when executed from subdirectories. Additionally, the strictness flags under [mypy-google.cloud.bigtable.*] are redundant due to ignore_errors = True and should be moved to the [mypy-google.cloud.bigtable.data.*] section.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
chalmerlowe
marked this pull request as ready for review
June 15, 2026 11:18
chalmerlowe
marked this pull request as draft
June 15, 2026 11:19
chalmerlowe
marked this pull request as ready for review
June 15, 2026 14:45
ohmayr
approved these changes
Jun 16, 2026
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jun 17, 2026
chalmerlowe added a commit
that referenced
this pull request
Jun 25, 2026
…-cloud-datastore POC (#17408) > [!note] > This is step one of a multi-step process. The work done here is outlined below. Additional steps (to be completed in other PRs) include: > * generate the remaining **generated packages** > * generate and/or post process **hybrid packages** This work: * Adds a centralized `mypy.ini` file at the root of the repository. * Updates GAPIC generator templates to omit local `mypy.ini` and dynamically resolve the root config via a `MYPY_CONFIG_FILE` constant. * Removes `mypy.ini` replacements from `datastore-integration.yaml` post-processing. * Regenerates `google-cloud-datastore` using the updated generator configurations to serve as a proof of concept. > [!note] > Work on strictly handwritten libraries is outside the scope of this PR and can be found here: #17409
chalmerlowe added a commit
that referenced
this pull request
Jul 21, 2026
…ten package noxfiles (#17409) * Relies on a centralized `mypy.ini` file at the root of the repository to consolidate all shared and package-specific mypy exceptions. * Deletes the individual `mypy.ini` files from handwritten libraries, establishing the root configuration as the source of truth. * Refactored their `noxfile.py` files to define `MYPY_CONFIG_FILE` dynamically and standardized their `session.run("mypy", ...)` invocations. > [!note] > Due to test failures outside the scope of this PR, neither google-cloud-crc32c nor bigframes are included in this PR. This [issue tracks those packages](#17606) to ensure their eventual completion > [!note] > bigquery and spanner were pulled out and placed in separate PRs due to excessive duration of their tests. PR #17640 and PR #17641 > [!note] > Work on generated libraries is outside the scope of this PR and can be found here: #17408 > [!note] > UPDATE (20260706): This PR is no longer blocked by #17607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is step one of a multi-step process. The work done here is outlined below.
Additional steps (to be completed in other PRs) include:
This work:
mypy.inifile at the root of the repository.mypy.iniand dynamically resolve the root config via aMYPY_CONFIG_FILEconstant.mypy.inireplacements fromdatastore-integration.yamlpost-processing.google-cloud-datastoreusing the updated generator configurations to serve as a proof of concept.Note
Work on strictly handwritten libraries is outside the scope of this PR and can be found here: #17409