Uh oh!
There was an error while loading. Please reload this page.
chore: add test sharding to unit tests - #17438
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces parallel execution for system tests and implements a sharding mechanism for CI jobs, including a new Python script to group packages and updates to the test runner script. Feedback on these changes focuses on improving reliability and safety: first, by using an EXIT trap in .kokoro/system.sh to guarantee cleanup of isolated gcloud configuration directories in case of test failures; and second, by avoiding global toggles of set -e in ci/run_conditional_tests.sh and instead capturing test exit codes using the || operator.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
parthea
left a comment
There was a problem hiding this comment.
Added suggestions to satisfy findings in https://github.com/googleapis/google-cloud-python/actions/runs/30566874706/job/90954041456 from PR https://github.com/googleapis/google-cloud-python/pulls
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Uh oh!
There was an error while loading. Please reload this page.
Added test sharding for unit and mypy tests:
initializejob to unit test CI. It analyzes the modified packages, and spawns up to MAX_SHARDS jobs for each supported Python runtimeunit test completestep, which is only green if all shards pass. This can be our new required check for unit testsBefore merge: