Skip to content

chore: re-enable cover tests - #17454

Merged
daniel-sanche merged 21 commits into
mainfrom
re-enable-cover
Jun 16, 2026
Merged

chore: re-enable cover tests#17454
daniel-sanche merged 21 commits into
mainfrom
re-enable-cover

Conversation

@daniel-sanche

@daniel-sanchedaniel-sanche commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

The cover CI test was silently failing open. This PR re-enables it

Fixes#17456

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@daniel-sanche
daniel-sanche marked this pull request as ready for review June 12, 2026 23:37
@daniel-sanche
daniel-sanche requested a review from a team as a code ownerJune 12, 2026 23:37
@daniel-sanche
daniel-sanche requested a review from a team as a code ownerJune 12, 2026 23:42

@chalmerlowechalmerlowe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-sanche
daniel-sanche marked this pull request as draft June 15, 2026 18:55
@daniel-sanche

Copy link
Copy Markdown
ContributorAuthor

I'm going to double-check how this works with hand-written libraries before merging

@daniel-sanche
daniel-sanche marked this pull request as ready for review June 15, 2026 20:43
@daniel-sanche
daniel-sanche requested a review from a team as a code ownerJune 15, 2026 20:43
@daniel-sanche
daniel-sanche merged commit b5e0d4b into mainJun 16, 2026
90 checks passed
@daniel-sanche
daniel-sanche deleted the re-enable-cover branch June 16, 2026 01:08
chalmerlowe pushed a commit that referenced this pull request Jun 25, 2026
The cover CI test was silently failing open. This PR re-enables it
Fixes#17456
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cover tests aren't running

2 participants

@daniel-sanche@chalmerlowe