Uh oh!
There was an error while loading. Please reload this page.
ci(google-auth): separate core vs extras lower-bound constraints - #17593
ci(google-auth): separate core vs extras lower-bound constraints#17593ohmayr wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the minimum required version of pyopenssl to 23.2.0 in setup.py and introduces a new constraints file for Python 3.14. The review feedback correctly identifies a dependency resolution conflict in the new constraints file, where pyopenssl 23.2.0 requires cryptography >= 41.0.1, but cryptography is currently pinned to 38.0.3. It is recommended to update the cryptography version to avoid installation failures.
Uh oh!
There was an error while loading. Please reload this page.
0a5609b to
1dd7463CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
0b141e6 to
b522b3fCompare50cc992 to
3140b0aCompare3140b0a to
55c9b18CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| session.install("oauth2client") | ||
| extras_str += ",rsa" | ||
| session.install("-e", f".[{extras_str}]", "-c", constraints_path) | ||
| extra_str = ".[testing,enterprise_cert,rsa]" |
There was a problem hiding this comment.
Isn't adding these extras (and oauthlib above) redundant, since the constraints-extas.txt file also contains them? Is there a benefit to installing them this way too? If so, should we be doing this for all extras?
There was a problem hiding this comment.
A -c constraints.txt file only constrains package versions for packages that pip is already installing; it does not trigger installation of any package by itself.
Uh oh!
There was an error while loading. Please reload this page.
daniel-sanche
commented
Jul 8, 2026
We discussed this offline, and found that new constraints files shouldn't be needed. We should be able to list all the constraints in a single place |
Core vs. Extras Constraints Separation:
constraints-*.txt: Core lower bounds only (pyasn1-modules, cryptography).constraints-extras-*.txt: Extras lower bounds (aiohttp, grpcio, requests, pyjwt, urllib3, packaging, rsa, etc.).