Skip to content

ci(google-auth): separate core vs extras lower-bound constraints - #17593

Closed
ohmayr wants to merge 6 commits into
mainfrom
fix-pyopenssl-compat-3.14
Closed

ci(google-auth): separate core vs extras lower-bound constraints#17593
ohmayr wants to merge 6 commits into
mainfrom
fix-pyopenssl-compat-3.14

Conversation

@ohmayr

@ohmayrohmayr commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Core vs. Extras Constraints Separation:

  • constraints-*.txt: Core lower bounds only (pyasn1-modules, cryptography).
  • constraints-extras-*.txt: Extras lower bounds (aiohttp, grpcio, requests, pyjwt, urllib3, packaging, rsa, etc.).

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum required version of pyopenssl to 23.2.0 in setup.py and introduces a new constraints file for Python 3.14. The review feedback correctly identifies a dependency resolution conflict in the new constraints file, where pyopenssl 23.2.0 requires cryptography >= 41.0.1, but cryptography is currently pinned to 38.0.3. It is recommended to update the cryptography version to avoid installation failures.

Comment threadpackages/google-auth/testing/constraints-3.14.txt Outdated
@ohmayr
ohmayrforce-pushed the fix-pyopenssl-compat-3.14 branch from 0a5609b to 1dd7463CompareJuly 6, 2026 19:07
@ohmayrohmayr changed the title fix(google-auth): raise minimum pyopenssl version to 23.2.0chore(auth): update lower bounds and testing constraints for Python 3.11 - 3.14 compatibilityJul 6, 2026
@ohmayr
ohmayr marked this pull request as ready for review July 6, 2026 19:35
@ohmayr
ohmayr requested review from a team as code ownersJuly 6, 2026 19:35
@ohmayrohmayr assigned daniel-sanche and unassigned ohmayrJul 6, 2026
Comment threadpackages/google-auth/testing/constraints-extras-3.10.txt Outdated
Comment threadpackages/google-auth/setup.py Outdated
Comment threadpackages/google-auth/testing/constraints-extras-3.10.txt Outdated
Comment threadpackages/google-auth/testing/constraints-3.11.txt Outdated
Comment threadpackages/google-auth/noxfile.py Outdated
Comment threadpackages/google-auth/setup.py Outdated
Comment threadpackages/google-auth/noxfile.py
Comment threadpackages/google-auth/noxfile.py Outdated
@partheaparthea assigned ohmayr and unassigned daniel-sancheJul 7, 2026
@ohmayr
ohmayrforce-pushed the fix-pyopenssl-compat-3.14 branch 2 times, most recently from 0b141e6 to b522b3fCompareJuly 7, 2026 22:48
@ohmayrohmayr changed the title chore(auth): update lower bounds and testing constraints for Python 3.11 - 3.14 compatibilityci(google-auth): separate core vs extras lower-bound constraintsJul 7, 2026
@ohmayr
ohmayrforce-pushed the fix-pyopenssl-compat-3.14 branch 2 times, most recently from 50cc992 to 3140b0aCompareJuly 7, 2026 23:01
@ohmayr
ohmayrforce-pushed the fix-pyopenssl-compat-3.14 branch from 3140b0a to 55c9b18CompareJuly 8, 2026 00:30
Comment threadpackages/google-auth/testing/constraints-3.14.txt
Comment threadpackages/google-auth/noxfile.py Outdated
Comment threadpackages/google-auth/noxfile.py Outdated
session.install("oauth2client")
extras_str += ",rsa"
session.install("-e", f".[{extras_str}]", "-c", constraints_path)
extra_str = ".[testing,enterprise_cert,rsa]"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't adding these extras (and oauthlib above) redundant, since the constraints-extas.txt file also contains them? Is there a benefit to installing them this way too? If so, should we be doing this for all extras?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A -c constraints.txt file only constrains package versions for packages that pip is already installing; it does not trigger installation of any package by itself.

Comment threadpackages/google-auth/noxfile.py Outdated
@daniel-sanche

Copy link
Copy Markdown
Contributor

We discussed this offline, and found that new constraints files shouldn't be needed. We should be able to list all the constraints in a single place

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ohmayr@daniel-sanche