Skip to content

docs(logging): fix StructuredLogHandler docstring parameter name - #17625

Merged
daniel-sanche merged 1 commit into
googleapis:mainfrom
lyushher:fix-structured-log-handler-docstring
Jul 6, 2026
Merged

docs(logging): fix StructuredLogHandler docstring parameter name#17625
daniel-sanche merged 1 commit into
googleapis:mainfrom
lyushher:fix-structured-log-handler-docstring

Conversation

@lyushher

@lyushherlyushher commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Update the StructuredLogHandler docstring to use project_id instead of project.
  • This matches the actual constructor parameter.

Fixes#17604

@lyushher
lyushher requested a review from a team as a code ownerJuly 3, 2026 16:43
@google-cla

google-claBot commented Jul 3, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gemini-code-assist[bot]
gemini-code-assistBot reviewed Jul 3, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the docstring of the StructuredLogHandler class in structured_log.py to rename the project argument to project_id, ensuring the documentation is accurate. There are no review comments, and I have no additional feedback to provide.

@partheaparthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 6, 2026
@parthea
parthea enabled auto-merge (squash) July 6, 2026 17:31
@yoshi-kokoroyoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 6, 2026
@hebaalazzeh
hebaalazzeh disabled auto-merge July 6, 2026 17:33
@hebaalazzeh

hebaalazzeh commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

LGTM

@daniel-sanche
daniel-sanche enabled auto-merge (squash) July 6, 2026 17:37
@daniel-sanche
daniel-sanche merged commit 32862f0 into googleapis:mainJul 6, 2026
30 of 31 checks passed
@release-pleaserelease-pleaseBot mentioned this pull request Jul 6, 2026
Merged
quirogas pushed a commit that referenced this pull request Jul 7, 2026
@release-please
chore: release main (#17600)
fc6b861
🤖 I have created a release *beep* *boop*
---
<details><summary>db-dtypes: 1.7.1</summary>
##
[1.7.1](db-dtypes-v1.7.0...db-dtypes-v1.7.1)
(2026-07-07)
### Bug Fixes
* avoid deprecated unitless operations for NumPy 2.5 compatibility
([#17589](#17589))
([d0b2abc](d0b2abc))
</details>
<details><summary>gapic-generator: 1.37.0</summary>
##
[1.37.0](gapic-generator-v1.36.0...gapic-generator-v1.37.0)
(2026-07-07)
### Features
* implement native PEP 0810 lazy loading
([#17591](#17591))
([8a1270c](8a1270c))
### Bug Fixes
* **deps:** bump google-api-core to 2.25.0
([#17599](#17599))
([8b359e2](8b359e2))
* **tests:** add --cov-append to gapic-generator and proto-plus to
preserve monorepo coverage
([#17603](#17603))
([2ddcf4d](2ddcf4d))
</details>
<details><summary>google-auth: 2.55.2</summary>
##
[2.55.2](google-auth-v2.55.1...google-auth-v2.55.2)
(2026-07-07)
### Bug Fixes
* **auth:** Agentic Identites mTLS gaps fix _is_mtls and SslCredentials.
([#17387](#17387))
([7bfa41a](7bfa41a))
* **auth:** align mTLS discovery and enforce fail-fast transport
configuration.
([#17470](#17470))
([f492d3d](f492d3d))
* **auth:** handle PermissionError on workload certificates to avoid
startup hang and crash
([#17568](#17568))
([f538ad8](f538ad8))
</details>
<details><summary>google-cloud-agentregistry: 0.1.0</summary>
## 0.1.0 (2026-07-07)
### Features
* **google/cloud/agentregistry/v1:** add google-cloud-agentregistry
([#17565](#17565))
([f479800](f479800))
</details>
<details><summary>google-cloud-biglake-hive: 0.3.1</summary>
##
[0.3.1](google-cloud-biglake-hive-v0.3.0...google-cloud-biglake-hive-v0.3.1)
(2026-07-07)
### Features
* update googleapis and regenerate
([#17635](#17635))
([9638879](9638879))
</details>
<details><summary>google-cloud-bigquery: 3.42.2</summary>
##
[3.42.2](google-cloud-bigquery-v3.42.1...google-cloud-bigquery-v3.42.2)
(2026-07-07)
### Bug Fixes
* **bigquery:** avoid SSLError retry loop
([#17489](#17489))
([8248d8e](8248d8e))
* include amended user agent in read client
([#17592](#17592))
([c43caee](c43caee))
</details>
<details><summary>google-cloud-binary-authorization: 1.18.0</summary>
##
[1.18.0](google-cloud-binary-authorization-v1.17.0...google-cloud-binary-authorization-v1.18.0)
(2026-07-07)
### Features
* update googleapis and regenerate
([#17635](#17635))
([9638879](9638879))
</details>
<details><summary>google-cloud-chronicle: 0.6.2</summary>
##
[0.6.2](google-cloud-chronicle-v0.6.1...google-cloud-chronicle-v0.6.2)
(2026-07-07)
### Features
* update googleapis and regenerate
([#17635](#17635))
([9638879](9638879))
</details>
<details><summary>google-cloud-dataform: 0.11.2</summary>
##
[0.11.2](google-cloud-dataform-v0.11.1...google-cloud-dataform-v0.11.2)
(2026-07-07)
### Features
* update googleapis and regenerate
([#17635](#17635))
([9638879](9638879))
</details>
<details><summary>google-cloud-dataproc: 5.30.0</summary>
##
[5.30.0](google-cloud-dataproc-v5.29.0...google-cloud-dataproc-v5.30.0)
(2026-07-07)
### Features
* update googleapis and regenerate
([#17635](#17635))
([9638879](9638879))
</details>
<details><summary>google-cloud-datastore: 2.26.0</summary>
##
[2.26.0](google-cloud-datastore-v2.25.0...google-cloud-datastore-v2.26.0)
(2026-07-07)
### Features
* update googleapis and regenerate
([#17635](#17635))
([9638879](9638879))
</details>
<details><summary>google-cloud-dialogflow: 2.50.0</summary>
##
[2.50.0](google-cloud-dialogflow-v2.49.0...google-cloud-dialogflow-v2.50.0)
(2026-07-07)
### Features
* update googleapis and regenerate
([#17635](#17635))
([9638879](9638879))
</details>
<details><summary>google-cloud-kms: 3.15.0</summary>
##
[3.15.0](google-cloud-kms-v3.14.0...google-cloud-kms-v3.15.0)
(2026-07-07)
### Features
* update googleapis and regenerate
([#17635](#17635))
([9638879](9638879))
</details>
<details><summary>google-cloud-logging: 3.16.1</summary>
##
[3.16.1](google-cloud-logging-v3.16.0...google-cloud-logging-v3.16.1)
(2026-07-07)
### Documentation
* **logging:** fix StructuredLogHandler docstring parameter name
([#17625](#17625))
([32862f0](32862f0)),
closes
[#17604](#17604)
</details>
<details><summary>google-cloud-modelarmor: 0.7.1</summary>
##
[0.7.1](google-cloud-modelarmor-v0.7.0...google-cloud-modelarmor-v0.7.1)
(2026-07-07)
### Features
* update googleapis and regenerate
([#17635](#17635))
([9638879](9638879))
</details>
<details><summary>google-cloud-network-security: 0.13.3</summary>
##
[0.13.3](google-cloud-network-security-v0.13.2...google-cloud-network-security-v0.13.3)
(2026-07-07)
### Features
* update googleapis and regenerate
([#17635](#17635))
([9638879](9638879))
</details>
<details><summary>google-cloud-saasplatform-saasservicemgmt:
0.7.1</summary>
##
[0.7.1](google-cloud-saasplatform-saasservicemgmt-v0.7.0...google-cloud-saasplatform-saasservicemgmt-v0.7.1)
(2026-07-07)
### Features
* update googleapis and regenerate
([#17635](#17635))
([9638879](9638879))
</details>
<details><summary>google-cloud-securesourcemanager: 0.6.1</summary>
##
[0.6.1](google-cloud-securesourcemanager-v0.6.0...google-cloud-securesourcemanager-v0.6.1)
(2026-07-07)
### Features
* update googleapis and regenerate
([#17635](#17635))
([9638879](9638879))
</details>
<details><summary>google-cloud-storage: 3.12.1</summary>
##
[3.12.1](google-cloud-storage-v3.12.0...google-cloud-storage-v3.12.1)
(2026-07-07)
### Bug Fixes
* **storage:** log occasional (1 in 5 million) additional bytes received
from GCS in read path
([#17423](#17423))
([335c12f](335c12f))
</details>
<details><summary>google-cloud-support: 0.5.1</summary>
##
[0.5.1](google-cloud-support-v0.5.0...google-cloud-support-v0.5.1)
(2026-07-07)
### Features
* update googleapis and regenerate
([#17635](#17635))
([9638879](9638879))
</details>
<details><summary>proto-plus: 1.28.1</summary>
##
[1.28.1](proto-plus-v1.28.0...proto-plus-v1.28.1)
(2026-07-07)
### Bug Fixes
* **tests:** add --cov-append to gapic-generator and proto-plus to
preserve monorepo coverage
([#17603](#17603))
([2ddcf4d](2ddcf4d))
</details>
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
---------
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniel-sanchedaniel-sanchedaniel-sanche approved these changes
@partheapartheaparthea approved these changes
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

StructuredLogHandler docstring documents project but parameter is project_id

5 participants

@lyushher@hebaalazzeh@daniel-sanche@parthea@yoshi-kokoro