Skip to content

feat(storage): support full_object_checksum in AsyncAppendableObjectWriter - #17658

Merged
chandra-siri merged 10 commits into
googleapis:mainfrom
chandra-siri:feat/appendable-checksum-validation
Jul 9, 2026
Merged

feat(storage): support full_object_checksum in AsyncAppendableObjectWriter#17658
chandra-siri merged 10 commits into
googleapis:mainfrom
chandra-siri:feat/appendable-checksum-validation

Conversation

@chandra-siri

@chandra-sirichandra-siri commented Jul 8, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Add support for verifying full_object_checksum on finalising/closing appendable object uploads.

@chandra-siri
chandra-siri requested a review from a team as a code ownerJuly 8, 2026 06:58
gemini-code-assist[bot]
gemini-code-assistBot reviewed Jul 8, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for CRC32C checksum validation when closing or finalizing an appendable object in AsyncAppendableObjectWriter, along with corresponding unit and system tests. The review feedback suggests several improvements: avoiding log pollution by removing the warning when finalizing without a checksum, omitting the object_checksums field entirely when it is None to prevent empty submessage serialization (and updating unit tests accordingly), and using a more specific exception class in system tests to avoid masking unexpected errors.

Comment threadpackages/google-cloud-storage/google/cloud/storage/asyncio/async_appendable_object_writer.py Outdated
Comment threadpackages/google-cloud-storage/google/cloud/storage/asyncio/async_appendable_object_writer.py Outdated
Comment threadpackages/google-cloud-storage/tests/system/test_zonal.py Outdated
Comment threadpackages/google-cloud-storage/tests/unit/asyncio/test_async_appendable_object_writer.py
@chandra-sirichandra-siri mentioned this pull request Jul 8, 2026
Merged
v-pratap
v-pratap approved these changes Jul 9, 2026
View reviewed changes
Comment threadpackages/google-cloud-storage/google/cloud/storage/asyncio/async_appendable_object_writer.py Outdated
Comment threadpackages/google-cloud-storage/tests/system/test_zonal.py Outdated
@chandra-siri
chandra-siri enabled auto-merge (squash) July 9, 2026 14:02
@chandra-siri
chandra-siri merged commit e08d5ca into googleapis:mainJul 9, 2026
30 checks passed
@release-pleaserelease-pleaseBot mentioned this pull request Jul 9, 2026
Merged
noahdietz pushed a commit that referenced this pull request Jul 13, 2026
@release-please
chore: release main (#17646)
7c18c24
🤖 I have created a release *beep* *boop*
---
<details><summary>google-apps-chat: 0.10.2</summary>
##
[0.10.2](google-apps-chat-v0.10.1...google-apps-chat-v0.10.2)
(2026-07-13)
### Features
* update googleapis and regenerate
([#17678](#17678))
([670917c](670917c))
</details>
<details><summary>google-auth: 2.56.0</summary>
##
[2.56.0](google-auth-v2.55.2...google-auth-v2.56.0)
(2026-07-13)
### Features
* **auth:** Implement python mtls helpers
([#17495](#17495))
([e7baed1](e7baed1))
### Bug Fixes
* **google-auth:** add aiohttp bound for Python 3.14
([#17654](#17654))
([b2ec761](b2ec761))
* **google-auth:** add bounds for urllib3 and packaging dependencies
([#17647](#17647))
([e9c6265](e9c6265))
* **google-auth:** add cryptography bound for Python 3.14
([#17649](#17649))
([e9ca4c4](e9ca4c4))
* **google-auth:** add gRPC extra and clean up obsolete TODOs
([#17644](#17644))
([6da41e8](6da41e8)),
closes
[#1735](#1735)
[#1736](#1736)
[#1739](#1739)
* **google-auth:** raise rsa extra lower bound to 4.0
([#17652](#17652))
([4087828](4087828))
</details>
<details><summary>google-cloud-apigee-registry: 0.10.1</summary>
##
[0.10.1](google-cloud-apigee-registry-v0.10.0...google-cloud-apigee-registry-v0.10.1)
(2026-07-13)
### Features
* update googleapis and regenerate
([#17678](#17678))
([670917c](670917c))
</details>
<details><summary>google-cloud-binary-authorization: 1.19.0</summary>
##
[1.19.0](google-cloud-binary-authorization-v1.18.0...google-cloud-binary-authorization-v1.19.0)
(2026-07-13)
### Features
* update googleapis and regenerate
([#17678](#17678))
([670917c](670917c))
</details>
<details><summary>google-cloud-documentai-toolbox: 0.17.1</summary>
##
[0.17.1](google-cloud-documentai-toolbox-v0.17.0...google-cloud-documentai-toolbox-v0.17.1)
(2026-07-13)
### Bug Fixes
* bump jinja2 from 3.1.0 to 3.1.6 in
/packages/google-cloud-documentai-toolbox
([#17630](#17630))
([4cfb931](4cfb931))
* bump pillow from 10.0.0 to 12.2.0 in
/packages/google-cloud-documentai-toolbox
([#17631](#17631))
([1838c35](1838c35))
</details>
<details><summary>google-cloud-memorystore: 0.5.2</summary>
##
[0.5.2](google-cloud-memorystore-v0.5.1...google-cloud-memorystore-v0.5.2)
(2026-07-13)
### Features
* update googleapis and regenerate
([#17678](#17678))
([670917c](670917c))
</details>
<details><summary>google-cloud-storage: 3.13.0</summary>
##
[3.13.0](google-cloud-storage-v3.12.1...google-cloud-storage-v3.13.0)
(2026-07-13)
### Features
* **storage:** add option to disable checksums and improve robustness of
full_object_checksum validation
([#17665](#17665))
([a5a717d](a5a717d))
* **storage:** support full_object_checksum in
AsyncAppendableObjectWriter
([#17658](#17658))
([e08d5ca](e08d5ca))
</details>
<details><summary>google-devicesandservices-health: 0.1.1</summary>
##
[0.1.1](google-devicesandservices-health-v0.1.0...google-devicesandservices-health-v0.1.1)
(2026-07-13)
### Features
* update googleapis and regenerate
([#17678](#17678))
([670917c](670917c))
</details>
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@v-pratapv-pratapv-pratap approved these changes
@krishnamd-jkpkrishnamd-jkpAwaiting requested review from krishnamd-jkp
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chandra-siri@v-pratap