Basic implementation of Translate API. by dhermes · Pull Request #1772 · googleapis/google-cloud-python

dhermes · 2016-05-03T22:11:37Z

~~Test forthcoming after API discussion.~~

Tests added in 2nd commit.

dhermes · 2016-05-03T22:37:17Z

I just added a GCLOUD_TESTS_API_KEY environment variable to Travis with an API key for our project tied to Travis.

Sign in to view

@@ -0,0 +1,18 @@
+# Copyright 2015 Google Inc. All rights reserved.


tseaver · 2016-05-12T23:06:48Z

pylint failure:

gcloud/translate/client.py:108:80: E501 line too long (80 > 79 characters)

dhermes · 2016-05-13T00:08:55Z

D'oh! Fixed the failure. @tseaver PTAL.

@jgeewax WDYT of the verb and verb_multiple approach (as is done in datastore)?

tseaver · 2016-05-13T02:20:42Z

LGTM

jgeewax · 2016-05-13T12:38:06Z

@dhermes : Didn't notice the updated comment -- lmk what you think.

Sign in to view

+
+.. automodule:: gcloud.translate.client
+ :members:
+ :undoc-members:


Sign in to view

+ :rtype: list
+ :returns: A list of dictionaries for each queried value. Each
+ dictionary typically contains three keys (though not
+ all will be present in all cases)


Test forthcoming after API discussion.

Also fixing a few broken docs.

- Dropping _zip_assert - Making multiple detections for a single value disallowed - Allow a default target language

dhermes · 2016-05-17T16:34:35Z

@tseaver @jgeewax PTAL. I reverted back to the original API surface.

Sign in to view

+class Client(object):
+ """Client to bundle configuration needed for API requests.
+
+ :type key: str


tseaver · 2016-05-17T17:42:52Z

@dhermes pylint failures: https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/130895364#L481-L482

dhermes · 2016-05-17T17:58:56Z

Thanks for the Pylint pointer. It was worse than a lint failure, was actually a broken system test (using the old key instead of api_key in the Client ctor).

dhermes · 2016-05-23T17:05:23Z

@tseaver @jgeewax Where do we stand here?

tseaver · 2016-05-23T17:45:54Z

LGTM

dhermes · 2016-05-23T21:36:43Z

@jgeewax I'll merge in 24 hours if I don't hear from you.

jgeewax · 2016-05-24T13:36:01Z

lgtm

dhermes · 2016-05-24T18:27:22Z

Blerg! I forgot to squash commits. I wish GitHub had a way to block until squashed (if the author so chooses).

* feat: support dict param for dataframe.agg() * fix lint * add more tests * fix lint

dhermes assigned tseaver May 3, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 3, 2016

dhermes added the api: translation Issues related to the Cloud Translation API API. label May 3, 2016

daspecster reviewed May 3, 2016
View reviewed changes

dhermes force-pushed the start-translate-api branch from 6faad34 to 03b4442Compare May 11, 2016 17:49

dhermes force-pushed the start-translate-api branch from 3fd72e2 to 92d4e3eCompare May 13, 2016 00:07

tseaver reviewed May 16, 2016
View reviewed changes

Comment threaddocs/translate-client.rst

.. automodule:: gcloud.translate.client
:members:
:undoc-members:
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

tseaver reviewed May 16, 2016
View reviewed changes

Comment threadgcloud/translate/client.py Outdated
:rtype: list
:returns: A list of dictionaries for each queried value. Each
dictionary typically contains three keys (though not
all will be present in all cases)
This comment was marked as spam.
Sign in to view

dhermes added 7 commits May 17, 2016 09:10

Basic implementation of Translate API.
6e566c6
Test forthcoming after API discussion.

Adding full test coverage.
039ae5e
Also fixing a few broken docs.

Adding system tests for translate API.
8a3a97d

Addressing review feedback.
01e8f9a
- Dropping _zip_assert - Making multiple detections for a single value disallowed - Allow a default target language

Fix Py3k failures.
13fb593

Fixing lint errors.
92e92a2

Reverting back to using str/list values in Translate.
2a4eaf8

dhermes force-pushed the start-translate-api branch from 92d4e3e to 2a4eaf8Compare May 17, 2016 16:33

Reverting system tests back to original implementation.
694384a

jgeewax reviewed May 17, 2016
View reviewed changes

Comment threadgcloud/translate/client.py Outdated
class Client(object):
"""Client to bundle configuration needed for API requests.

:type key: str
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

Renaming key->api_key and fixing copyright years.
beda548

Updating system test to use api_key (after change).
fcd6fee

Adding notes about detection confidence.
b759a76

dhermes mentioned this pull request May 17, 2016
Initial vision API addition. #1803
Closed
6 tasks

dhermes merged commit 503cd32 into googleapis:masterMay 24, 2016

dhermes deleted the start-translate-api branch May 24, 2016 18:11

dhermes mentioned this pull request Jun 7, 2016
Cut 0.15.0 release. #1842
Merged

parthea pushed a commit that referenced this pull request Apr 1, 2026
feat: support dict param for dataframe.agg() (#1772)
6528804
* feat: support dict param for dataframe.agg() * fix lint * add more tests * fix lint

		@@ -0,0 +1,18 @@
		# Copyright 2015 Google Inc. All rights reserved.

Uh oh!

Conversation

dhermes commented May 3, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhermes commented May 3, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented May 12, 2016

Uh oh!

dhermes commented May 13, 2016

Uh oh!

tseaver commented May 13, 2016

Uh oh!

jgeewax commented May 13, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented May 17, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented May 17, 2016

Uh oh!

dhermes commented May 17, 2016

Uh oh!

dhermes commented May 23, 2016

Uh oh!

tseaver commented May 23, 2016

Uh oh!

dhermes commented May 23, 2016

Uh oh!

jgeewax commented May 24, 2016

Uh oh!

dhermes commented May 24, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dhermes commented May 3, 2016•
edited
Loading