Skip to content

chore: regenerate google-cloud-bigtable - #17722

Merged
parthea merged 10 commits into
mainfrom
fix-bigtable-tests
Jul 15, 2026
Merged

chore: regenerate google-cloud-bigtable#17722
parthea merged 10 commits into
mainfrom
fix-bigtable-tests

Conversation

@parthea

@partheaparthea commented Jul 15, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR also includes the fixes from #17707

Closes#17719
Closes#17707
Fixes#17709

gemini-code-assist[bot]
gemini-code-assistBot reviewed Jul 15, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the delete_rows helper in the system tests to chunk row deletions into batches of 5,000. This prevents hitting the 4MB gRPC payload limit and avoids transient network timeouts. Additionally, the gRPC stream is now consumed to guarantee execution. The review feedback suggests converting self.rows to a list before slicing to avoid potential TypeErrors with non-sequence iterables, and checking the status of each entry in the stream response instead of silently ignoring them to prevent masking deletion failures.

Comment threadpackages/google-cloud-bigtable/tests/system/data/test_system_async.py Outdated
Comment threadpackages/google-cloud-bigtable/tests/system/data/test_system_async.py Outdated
@partheaparthea changed the title for testing purposeschore: regenerate google-cloud-bigtableJul 15, 2026
@parthea
parthea marked this pull request as ready for review July 15, 2026 17:26
@parthea
parthea requested review from a team as code ownersJuly 15, 2026 17:26
@parthea
parthea merged commit 543a5fd into mainJul 15, 2026
43 checks passed
@parthea
parthea deleted the fix-bigtable-tests branch July 15, 2026 17:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noahdietznoahdietznoahdietz approved these changes
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

google-cloud-bigtable system tests fail with 504 Deadline Exceeded

3 participants

@parthea@noahdietz@chalmerlowe