Skip to content

Avoid get / set of IAM policy if current account doesn't have permission - #1782

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:1687-1743-pubsub-iam_system_tests
May 11, 2016
Merged

Avoid get / set of IAM policy if current account doesn't have permission#1782
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:1687-1743-pubsub-iam_system_tests

Conversation

@tseaver

@tseavertseaver commented May 6, 2016

Copy link
Copy Markdown
Contributor

Uses #1776 as a base.

Closes#1687.

Closes#1743.

@tseavertseaver added testing api: pubsub Issues related to the Pub/Sub API. labels May 6, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 6, 2016
@tseaver

Copy link
Copy Markdown
ContributorAuthor

@dhermes PTAL: this PR illustrates using the enumerated pubsub permissions from #1775 in a "look-before-you-leap" way to implement #1743. It also exercises the {Topic,Subscription}check_iam_permissions correctly, as discovered in #1687.

@dhermes

Copy link
Copy Markdown
Contributor

@tseaver Can you ping me once this is rebased?

@tseaver

Copy link
Copy Markdown
ContributorAuthor

@dhermes rebased against master. PTAL

@dhermes

Copy link
Copy Markdown
Contributor

Sorry for the delay. On it now.

@dhermes

Copy link
Copy Markdown
Contributor

LGTM

@tseaver
tseaver merged commit 096b5f6 into googleapis:masterMay 11, 2016
@tseaver
tseaver deleted the 1687-1743-pubsub-iam_system_tests branch May 11, 2016 18:19
@tseavertseaver mentioned this pull request May 16, 2016
parthea pushed a commit that referenced this pull request Mar 6, 2026
… API (#1782)
* docs: update client_query_w_named_params.py to use query_and_wait API
* Update client_query_w_named_params.py
lint
---------
Co-authored-by: Salem Boyland <salemb@google.com>
Co-authored-by: Kira <kirnendra@google.com>
chalmerlowe pushed a commit that referenced this pull request Mar 26, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.
Librarian Version: v1.0.2-0.20251119154421-36c3e21ad3ac
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:8e2c32496077054105bd06c54a59d6a6694287bc053588e24debe6da6920ad91
<details><summary>google-cloud-storage: 3.10.1</summary>
##
[3.10.1](googleapis/python-storage@v3.10.0...v3.10.1)
(2026-03-23)
### Bug Fixes
* raise ValueError if api_endpoint is unset when using
AnonymousCredentials in AsyncGrpcClient. (#1778)
([17828ea3](googleapis/python-storage@17828ea3))
</details>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsubIssues related to the Pub/Sub API.cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver@dhermes@googlebot