Uh oh!
There was an error while loading. Please reload this page.
chore(generator): add compatability layer templates - #17886
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a compatibility module (_compat.py) and its corresponding unit tests (test_compat.py) to the GAPIC generator templates, updating the generator to allow these private templates and prevent them from being skipped when empty. The review feedback correctly identifies that prepending # before the license include statement in the template files results in double comment characters (# #) in the generated golden files, and suggests removing the leading # to fix this formatting issue.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This PR consolidates the common code into a temporary compatibility layer as a fallback implementation as we move this code to google-api-core. Once, the minimum supported version of google-api-core has these functions we will clean up this layer.
Towards: #17883