Skip to content

chore(ci): skip packages with unsupported pre-release deps in import profiler - #18033

Merged
hebaalazzeh merged 4 commits into
mainfrom
skip-unsupported-prerelease-packages
Aug 8, 2026
Merged

chore(ci): skip packages with unsupported pre-release deps in import profiler#18033
hebaalazzeh merged 4 commits into
mainfrom
skip-unsupported-prerelease-packages

Conversation

@hebaalazzeh

@hebaalazzehhebaalazzeh commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Skip packages with heavy native/scientific dependencies (bigframes, pandas-gbq,
google-cloud-documentai-toolbox, db-dtypes, bigquery-magics) that fail to build
on Python 3.15 due to missing pre-built wheels.

Test PR: #18034

Fixes: b/535231604

@hebaalazzehhebaalazzeh changed the title chore(ci): skip packages with unsupported pre-release deps in import …chore(ci): skip packages with unsupported pre-release deps in import profilerAug 7, 2026

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies ci/run_single_test.sh to gracefully handle pre-release Python versions (such as Python 3.15) by skipping unsupported packages and handling installation failures during import_profile tests. However, the feedback highlights critical issues where these skips and fallbacks are applied unconditionally across all Python versions, which would silently ignore genuine installation failures on stable Python environments. The reviewer recommends restricting these workarounds specifically to pre-release Python versions and adding detailed logging for successful runs.

Comment threadci/run_single_test.sh Outdated
Comment threadci/run_single_test.sh
Comment threadci/run_single_test.sh
@hebaalazzehhebaalazzeh self-assigned this Aug 7, 2026
@hebaalazzeh
hebaalazzeh marked this pull request as ready for review August 8, 2026 00:25
@hebaalazzeh
hebaalazzeh requested a review from a team as a code ownerAugust 8, 2026 00:25
Comment threadci/run_single_test.sh
Comment on lines +155 to +157
elif [[ "${PY_VERSION}" != "3.15"* ]]; then
exit 1
fi

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking: exit 1 runs inside a subshell (...), so it will only exit the child process rather than failing the outer script if baseline pip install fails on non-3.15 Python versions (due to set +e).

Consider checking the subshell exit status in the parent shell or restructuring to if ! ( ... ); then exit 1; fi to ensure baseline build failures properly fail CI.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

@hebaalazzeh
hebaalazzeh enabled auto-merge (squash) August 8, 2026 02:00
@hebaalazzeh
hebaalazzeh merged commit 5e0c2ff into mainAug 8, 2026
35 checks passed
@hebaalazzeh
hebaalazzeh deleted the skip-unsupported-prerelease-packages branch August 8, 2026 02:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hebaalazzeh@ohmayr