Uh oh!
There was an error while loading. Please reload this page.
feat(api_core): add deprecation warning for grpcio < 1.83.0 for PQC - #18045
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a dependency check and warning for grpcio < 1.83.0 to support the migration to Post-Quantum Cryptography (PQC). It updates version parsing to handle pre-release versions, fixes an f-string formatting bug in deprecation warnings, and adds corresponding unit tests. Feedback suggests replacing the placeholder XXXXX in the pyproject.toml warning filter with the actual GitHub issue number before merging.
Uh oh!
There was an error while loading. Please reload this page.
daniel-sanche
left a comment
There was a problem hiding this comment.
A couple questions to make sure I'm understanding this right, but mostly looks good so far
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Adds deprecation warnings for
grpcio < 1.83.0togoogle.api_core._python_package_support.In October 2026, Google Cloud client libraries will raise their minimum requirements to enforce
grpcio >= 1.83.0for Post-Quantum Cryptography (PQC) support.Towards: b/537446703