Skip to content

fix(bigtable): surface swallowed MutationsBatcher flush errors - #18145

Open
mutianf wants to merge 2 commits into
googleapis:mainfrom
mutianf:fix-bigtable-batcher-error-handling
Open

fix(bigtable): surface swallowed MutationsBatcher flush errors#18145
mutianf wants to merge 2 commits into
googleapis:mainfrom
mutianf:fix-bigtable-batcher-error-handling

Conversation

@mutianf

@mutianfmutianf commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

…op one-shot timer
Change-Id: I046bb0ee2c92ef20f842dea8eb5480e85717e87e
@mutianf
mutianf requested a review from a team as a code ownerAugust 18, 2026 20:55

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deprecates the background timer-based flush in MutationsBatcher and updates the close() method to handle exceptions during the final synchronous flush, ensuring that executor shutdown and cleanup are not aborted. The reviewer pointed out that catching a generic Exception in close() could lead to nested MutationsBatchError exceptions, and suggested explicitly catching and unpacking MutationsBatchError to maintain a flat list of exceptions.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@mutianf
mutianf enabled auto-merge (squash) August 18, 2026 21:01
@mutianfmutianf changed the title fix(bigtable): surface swallowed MutationsBatcher flush errors and dr…fix(bigtable): surface swallowed MutationsBatcher flush errorsAug 18, 2026
@mutianf
mutianf disabled auto-merge August 18, 2026 21:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mutianf@daniel-sanche@sushanb