Skip to content

Repair logging client 'list_*' methods. - #1823

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:1820-logging-repair_client_list_methods
May 26, 2016
Merged

Repair logging client 'list_*' methods.#1823
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:1820-logging-repair_client_list_methods

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

Broken in #1820. Borked logging system tests pass with this patch.

@tseavertseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: logging Issues related to the Cloud Logging API. labels May 26, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 26, 2016
@dhermes

Copy link
Copy Markdown
Contributor

LGTM

@tseaver
tseaver merged commit d4ff022 into googleapis:masterMay 26, 2016
@tseaver
tseaver deleted the 1820-logging-repair_client_list_methods branch May 26, 2016 16:33
@dhermesdhermes mentioned this pull request Jun 7, 2016
parthea pushed a commit that referenced this pull request Nov 24, 2025
parthea added a commit that referenced this pull request Mar 6, 2026
* chore: use mock from unittest
* correct user_credentials_test.py
* add try except for Python 3.7
* fixes linting
* adjustments to testing suite to account for dependencies
* updates to mypy_samples.py
* linting for noxfile.py
---------
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: loggingIssues related to the Cloud Logging API.cla: yesThis human has signed the Contributor License Agreement.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver@dhermes@googlebot