Skip to content

Ease construction of 'Sink'/'Metric' instances to be reloaded. - #1862

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:1856-logging-ease_lookup_of_existing_sinks_metrics
Jun 16, 2016
Merged

Ease construction of 'Sink'/'Metric' instances to be reloaded.#1862
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:1856-logging-ease_lookup_of_existing_sinks_metrics

Conversation

@tseaver

@tseavertseaver commented Jun 15, 2016

Copy link
Copy Markdown
Contributor

Closes#1856.

@daspecster PTAL

@tseavertseaver added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: logging Issues related to the Cloud Logging API. labels Jun 15, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 15, 2016
@tseaver

tseaver commented Jun 15, 2016

Copy link
Copy Markdown
ContributorAuthor

/cc @waprin

daspecster
daspecster reviewed Jun 15, 2016
View reviewed changes
Comment threadgcloud/logging/sink.py
for the sink (which requires a project).
"""
def __init__(self, name, filter_, destination, client):
def __init__(self, name, filter_=None, destination=None, client=None):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@daspecster

daspecster commented Jun 16, 2016

Copy link
Copy Markdown
Contributor

@tseaver LGTM!

@tseaver
tseaver merged commit 488b600 into googleapis:masterJun 16, 2016
@tseaver
tseaver deleted the 1856-logging-ease_lookup_of_existing_sinks_metrics branch June 16, 2016 16:56
parthea pushed a commit that referenced this pull request Oct 21, 2023
@dpebot@busunkim96
Auto-update dependencies. [(#1862)](GoogleCloudPlatform/python-docs-s…
aeeed3b
…amples#1862)
parthea pushed a commit that referenced this pull request Nov 26, 2025
@ohmayr
chore: update prev version in state (#1862)
aec782f
parthea pushed a commit that referenced this pull request Apr 1, 2026
@sycai
refactor: rename scalars_types_df to scalar_types_df (#1862)
5339147
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: loggingIssues related to the Cloud Logging API.cla: yesThis human has signed the Contributor License Agreement.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver@daspecster@googlebot