Switch to codecov.io by daspecster · Pull Request #1876 · googleapis/google-cloud-python

daspecster · 2016-06-20T20:24:04Z

No description provided.

Sign in to view


 after_success:
- - tox -e coveralls
+ - bash <(curl -s https://codecov.io/bash)


daspecster · 2016-06-20T20:56:13Z

Possibly an example when it finishes generating...
https://codecov.io/github/daspecster/gcloud-python/commit/8f90abc07f33c0b84522ae58377cdcbaca569f65

codecov-io · 2016-06-20T21:19:55Z

Current coverage is 100%

No coverage report found for master at bd6435a.
Powered by Codecov. Last updated by bd6435a...6d08b77

daspecster · 2016-06-20T21:27:23Z

Yeah still playing with it.
I need to get the coverage xml generated before codecov runs.

On Monday, June 20, 2016, Codecov notifications@github.com wrote:

Current coverage
https://codecov.io/gh/GoogleCloudPlatform/gcloud-python/pull/1876?src=pr
is 100%
No coverage report found for master at 986302f
986302f
.
Powered by Codecov https://codecov.io?src=pr. Last updated by
986302f...60c0364
https://codecov.io/gh/GoogleCloudPlatform/gcloud-python/compare/986302f3db5ab71e0951fa4fab796333d7d7cece...60c03644ff146537e351822b77bd4a27732c06aa
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1876 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AALvyGawrhgLR23ki28X9RDdsOmdeqt7ks5qNwP7gaJpZM4I6FhG
.

Tom Schultz

daspecster · 2016-06-20T21:45:14Z

@dhermes the last build worked.

Travis:
https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/139037369#L778

codecov:
https://codecov.io/gh/GoogleCloudPlatform/gcloud-python/tree/60c03644ff146537e351822b77bd4a27732c06aa/gcloud

Sign in to view

+basepython =
+ python2.7
+passenv =
+ CI TRAVIS_BUILD_ID TRAVIS TRAVIS_BRANCH TRAVIS_JOB_NUMBER TRAVIS_PULL_REQUEST TRAVIS_JOB_ID TRAVIS_REPO_SLUG TRAVIS_COMMIT


dhermes · 2016-06-20T22:05:35Z

LGTM, please squash. Also we should make sure codecov.io adds a check to this PR before merging

dhermes · 2016-06-20T22:06:17Z

Also the coveralls badge should be replaced

daspecster · 2016-06-20T22:13:46Z

@dhermes, I don't have admin rights to the repo to add a github check.

daspecster · 2016-06-20T22:16:48Z

Looks like we're not alone!
https://codecov.io/gh/googlecloudplatform

dhermes · 2016-06-20T22:21:29Z

@daspecster Which page do you need admin rights for? I'm on https://github.com/GoogleCloudPlatform/gcloud-python/settings/hooks trying to add the service but can't find it

dhermes · 2016-06-20T22:26:45Z

OK figured it out on https://codecov.io/gh/GoogleCloudPlatform/gcloud-python/settings

Here is the badge FYI


.. image:: https://codecov.io/gh/GoogleCloudPlatform/gcloud-python/branch/master/graph/badge.svg
:target: https://codecov.io/gh/GoogleCloudPlatform/gcloud-python

dhermes · 2016-06-20T22:27:54Z

@daspecster Now that the hook has been added, can you add a commit with the badge so we can test it?

daspecster · 2016-06-20T22:28:16Z

Awesome! I was looking.

I put http://codecov.io/github/googlecloudplatform/gcloud-python/coverage.svg?branch=master for the badge target in the readme but I'll change it to yours.

dhermes · 2016-06-20T22:29:49Z

I just copied that RST snippet from https://codecov.io/gh/GoogleCloudPlatform/gcloud-python/settings/badge Where'd you get the other one?

daspecster · 2016-06-20T22:30:32Z

I think I saw it in their docs somewhere.

dhermes · 2016-06-20T22:33:10Z

codecov runtests: commands[1] | codecov
_____ _
/ ____| | |
| | ___ __| | ___ ___ _____ __
| | / _ \ / _ |/ _ \/ __/ _ \ \ / /
| |___| (_) | (_| | __/ (_| (_) \ V /
\_____\___/ \____|\___|\___\___/ \_/
v2.0.5
==> Detecting CI provider
-> Got branch from git/hg
-> Got sha from git/hg
==> Preparing upload
Error: Missing repository upload token
Tip: See all example repositories: https://github.com/codecov?query=example
Support channels:
Email: hello@codecov.io
IRC: #codecov
Gitter: https://gitter.im/codecov/support
Twitter: @codecov

dhermes · 2016-06-20T22:46:41Z

Still no check, though it worked

codecov runtests: commands[1] | codecov
_____ _
/ ____| | |
| | ___ __| | ___ ___ _____ __
| | / _ \ / _ |/ _ \/ __/ _ \ \ / /
| |___| (_) | (_| | __/ (_| (_) \ V /
\_____\___/ \____|\___|\___\___/ \_/
v2.0.5
==> Detecting CI provider
Travis Detected
==> Preparing upload
==> Processing gcov (disable by -X gcov)
Executing gcov (find /home/travis/build/GoogleCloudPlatform/gcloud-python -type f -name '*.gcno' -exec gcov -pb {} +)
==> Collecting reports
Generating coverage xml reports for Python
+ /home/travis/build/GoogleCloudPlatform/gcloud-python/coverage.xml bytes=1274444
==> Appending environment variables
+ TRAVIS_OS_NAME
==> Uploading
.url https://codecov.io
.query commit=51af5e55de35c61123d61d8cc1eb76eca06b3333&service=travis&pr=1876&package=py2.0.5&job=139057017&branch=master&slug=GoogleCloudPlatform%2Fgcloud-python&build=3845.1
Pinging Codecov...
Uploading to S3...

daspecster · 2016-06-20T22:50:32Z

Hmmm

daspecster · 2016-06-21T00:05:18Z

@dhermes after some digging, I think we need that codecov.yml file there to get it to trigger status checks. Let me know if one shows up now?

daspecster · 2016-06-21T17:34:26Z

@dhermes, can you add the integration here https://github.com/integrations/codecov to the GoogleCloudApplication org if possible.
There might be something to do with the third-party restrictions as well.

I thinkhttps://github.com/organizations/GoogleCloudPlatform/settings/oauth_application_policy
and/or
https://github.com/organizations/GoogleCloudPlatform/settings/applications/

CodeCov uses all github permissions so I think we have to get it setup on the org side.

dhermes · 2016-06-21T20:24:30Z

I don't know if I have admin rights / don't see any "Add" button on the integrations page (I visited it multiple times yesterday trying to figure out what to click).

daspecster · 2016-06-21T20:50:40Z

Would this be something @jgeewax might have to do?

dhermes · 2016-06-21T21:23:53Z

Maybe

dhermes · 2016-06-21T21:24:32Z

@daspecster Where did the previous post from the codecov bot come from?

daspecster · 2016-06-21T21:44:57Z

If you change this value it will post a comment.
https://github.com/GoogleCloudPlatform/gcloud-python/pull/1876/files#diff-8bc9db6adba7208e25c96be322351063R1

That link anchors weirdly...it's line 1 of codecov.yml.

daspecster · 2016-06-22T20:20:27Z

@jgeewax, if you're game, can we enable codecov in the organization apps/oauth?

jgeewax · 2016-07-05T14:01:57Z

👍

daspecster · 2016-07-05T14:02:54Z

Awesome thanks!

daspecster · 2016-07-06T18:00:47Z

Hmmm, still not showing up in here. Could someone check and see if codecov is in the projected branch settings now?

daspecster · 2016-07-13T19:07:47Z

I tried to reset the webhook.
Looks like there is still an issue on the github permissions side.

tseaver · 2016-07-14T14:55:47Z

FWIW, the webhook is already in place.

daspecster · 2016-07-14T15:05:06Z

@tseaver, if you go here can you click on the "reset webhook" button with any success?

If that doesn't start working then we could also just turn the integration back on to get codecov to post a comment about the coverage.

I'm thinking that this might have to get into master to fully work. We could change this so it does both coveralls and codecov to test it.

tseaver · 2016-07-14T15:49:40Z

Can you click on the "reset webhook" button with any success?

Nope, I get the same error you posted.

If that doesn't start working then we could also just turn the integration back on to get codecov to post a comment about the coverage.

I don't like those comments: I would rather have it be a "check".

I'm thinking that this might have to get into master to fully work. We could change this so it does both coveralls and codecov to test it.

Let's try that. We can drop coveralls in a follow-up PR.

tseaver · 2016-07-14T17:43:36Z

LGTM

Change codecov settings.

daspecster · 2016-07-14T18:02:49Z

I squashed some of the commits and when travis passes I'll merge.

…o_dataframe` (#1876) * add regression tests for empty dataframe * fix arrow test to be compatible with old pyarrow

Co-authored-by: Tim Sweña (Swast) <swast@google.com>

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2016

daspecster mentioned this pull request Jun 20, 2016
Have travis-ci run tox -e cover to catch code branch coverage misses #1872
Closed

dhermes reviewed Jun 20, 2016
View reviewed changes

Comment thread.travis.yml Outdated

after_success:
- tox -e coveralls
- bash <(curl -s https://codecov.io/bash)
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

daspecster force-pushed the switch-to-codecovio branch 2 times, most recently from 5915215 to 60c0364Compare June 20, 2016 21:14

dhermes reviewed Jun 20, 2016
View reviewed changes

Comment threadtox.ini Outdated
basepython =
python2.7
passenv =
CI TRAVIS_BUILD_ID TRAVIS TRAVIS_BRANCH TRAVIS_JOB_NUMBER TRAVIS_PULL_REQUEST TRAVIS_JOB_ID TRAVIS_REPO_SLUG TRAVIS_COMMIT
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

Switch to codecov.ioclosesgoogleapis#1872
1d5973e

daspecster force-pushed the switch-to-codecovio branch from b2ff4f2 to 1d5973eCompare June 20, 2016 22:12

tseaver added the testing label Jul 11, 2016

daspecster force-pushed the switch-to-codecovio branch from d9999f4 to 6d08b77Compare July 14, 2016 15:54

daspecster added 3 commits July 14, 2016 14:02

Update badge url.
8967379

Add codecov.yml to trigger status check.
d6db37b
Change codecov settings.

Add coveralls back while testing codecov.
58cdf26

daspecster force-pushed the switch-to-codecovio branch from 6d08b77 to 58cdf26Compare July 14, 2016 18:02

daspecster merged commit 1942f2d into googleapis:masterJul 14, 2016

daspecster mentioned this pull request Jul 18, 2016
Code branch test coverage #1993
Closed

This was referenced Aug 3, 2016
Prepare 0.18.0 release #2044
Closed
Prepare 0.18.0 release. #2048
Merged

daspecster deleted the switch-to-codecovio branch January 24, 2017 15:18

parthea pushed a commit that referenced this pull request Nov 26, 2025
chore(tests): update secret (#1876)
01c25c1

parthea pushed a commit that referenced this pull request Mar 6, 2026
fix: avoid "Unable to determine type" warning with JSON columns in `t…
b3f7595
…o_dataframe` (#1876) * add regression tests for empty dataframe * fix arrow test to be compatible with old pyarrow

parthea pushed a commit that referenced this pull request Apr 1, 2026
docs: update gsutil commands to gcloud commands (#1876)
32d6a40
Co-authored-by: Tim Sweña (Swast) <swast@google.com>

Uh oh!

Conversation

daspecster commented Jun 20, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

daspecster commented Jun 20, 2016

Uh oh!

codecov-io commented Jun 20, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current coverage is 100%

Uh oh!

daspecster commented Jun 20, 2016

Uh oh!

daspecster commented Jun 20, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Jun 20, 2016

Uh oh!

dhermes commented Jun 20, 2016

Uh oh!

daspecster commented Jun 20, 2016

Uh oh!

daspecster commented Jun 20, 2016

Uh oh!

dhermes commented Jun 20, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhermes commented Jun 20, 2016

Uh oh!

dhermes commented Jun 20, 2016

Uh oh!

daspecster commented Jun 20, 2016

Uh oh!

dhermes commented Jun 20, 2016

Uh oh!

daspecster commented Jun 20, 2016

Uh oh!

dhermes commented Jun 20, 2016

Uh oh!

dhermes commented Jun 20, 2016

Uh oh!

daspecster commented Jun 20, 2016

Uh oh!

daspecster commented Jun 21, 2016

Uh oh!

daspecster commented Jun 21, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhermes commented Jun 21, 2016

Uh oh!

daspecster commented Jun 21, 2016

Uh oh!

dhermes commented Jun 21, 2016

Uh oh!

dhermes commented Jun 21, 2016

Uh oh!

daspecster commented Jun 21, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daspecster commented Jun 22, 2016

Uh oh!

jgeewax commented Jul 5, 2016

Uh oh!

daspecster commented Jul 5, 2016

Uh oh!

daspecster commented Jul 6, 2016

Uh oh!

daspecster commented Jul 13, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tseaver commented Jul 14, 2016

Uh oh!

codecov-io commented Jun 20, 2016•
edited
Loading

dhermes commented Jun 20, 2016•
edited
Loading

daspecster commented Jun 21, 2016•
edited
Loading

daspecster commented Jun 21, 2016•
edited
Loading

daspecster commented Jul 13, 2016•
edited
Loading