Skip to content

Clarify handling of V2 'ReadRowsResponse' error cases - #1915

Merged
tseaver merged 2 commits into
googleapis:bigtable-v2from
tseaver:bigtable-v2-readrowsresponse-error-cases
Jun 27, 2016
Merged

Clarify handling of V2 'ReadRowsResponse' error cases#1915
tseaver merged 2 commits into
googleapis:bigtable-v2from
tseaver:bigtable-v2-readrowsresponse-error-cases

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

Distinguish response-level errors from invalid chunks.

JSON testcases ending in an incomplete row should not raise errors.

For "invalid" JSON testcases, verify that completed, non-error rows match expected results.

Assert that the state is 'ROW_IN_PROGRESS', and check that the completed
rows match the expected results.
@tseavertseaver added the api: bigtable Issues related to the Bigtable API. label Jun 27, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 27, 2016
@tseavertseaver mentioned this pull request Jun 27, 2016
Verify that completed, non-error rows match expected results after an
invalid chunk testcase.
@tseaver
tseaver merged commit fcc3751 into googleapis:bigtable-v2Jun 27, 2016
@tseaver
tseaver deleted the bigtable-v2-readrowsresponse-error-cases branch June 27, 2016 16:07
parthea pushed a commit that referenced this pull request Mar 6, 2026
* add new presubmit for test purposes
* add additional sessions
* Update .kokoro/presubmit/presubmit-2.cfg
* Update .kokoro/presubmit/presubmit-2.cfg
* added timer to nox sessions
* Update .kokoro/presubmit/presubmit-2.cfg
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* removes references to most environment variables
* testing the use of base names for the nox sessions
* removes references to unneeded linting and typing env variables
* change file name and update env_vars in presubmit-2
* remove timed decorators
* revert several files
* Update noxfile.py
* remove test, remove unneeded vars, etc
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtableIssues related to the Bigtable API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tseaver@googlebot