Uh oh!
There was an error while loading. Please reload this page.
Resolve issues with GAE and os.path.expanduser() - #1924
Merged
daspecster merged 2 commits intoJun 28, 2016
Conversation
| import pwd | ||
| del pwd | ||
| sys.modules['pwd'] = None # Blocks pwd from being imported. | ||
| project_id = self.callFUT('test-project-id') |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
daspecster
commented
Jun 28, 2016
ContributorAuthor
@tseaver, I cleaned up some redundant code as well. |
| # Workaround for GAE not supporting pwd which is used by expanduser. | ||
| try: | ||
| full_config_path = os.path.expanduser(DEFAULT_CONFIGURATION_PATH) | ||
| search_paths.append(full_config_path) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
daspecsterforce-pushed
the
fix-gae-default-project-id
branch
from
June 28, 2016 15:37
b806b92 to
b1d56a5Comparetheacodes
commented
Jun 28, 2016
Contributor
FWIW, I'm filing a bug to get pwd enabled on GAE. |
tseaver
commented
Jun 28, 2016
Contributor
LGTM |
parthea pushed a commit
that referenced
this pull request
Apr 1, 2026
* fix: Series.str.isdigit in unicode subscripts * fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.path.expanduserimports thepwdmodule which is not supported by GAE.This should resolve#1922.