Install gRPC et al for testing except py26/lint/docs-rtd by tseaver · Pull Request #1943 · googleapis/google-cloud-python

tseaver · 2016-06-29T22:23:08Z

Rationalize tox vs. gRPC:

Install grpcio and related deps by default, and omit adding _testing to PYTHONPATH.
For Python 2.6, and lint, RTD, suppress installing gRPC-related deps, and add _testing to PYTHONPATH.

Bump minimum version for grpcio to 0.15.0.

Fix up Py3k failures with grpcio installed.

@daspecster, @dhermes Maybe this should land before 0.17.0?

tseaver · 2016-06-29T22:27:15Z

I'm going to go ahead with 0.17.0 without this one.

dhermes · 2016-06-29T23:13:35Z

Changes look mostly good. Failures caused by what?

tseaver · 2016-06-29T23:32:40Z

Ugh, no idea -- I can't reproduce on my Ubuntu Trusty machine here. "Two hard things in computer science: caching, naming things, and off-by-one errors."

daspecster · 2016-06-30T02:40:11Z

@tseaver it did the same thing to me on OSX, someone reported it here and I opened an issue on grpc.
However it looks like it was two different things.

I believe grpc needs to do a release before this works again.
grpc/grpc#7135 (comment)

How I reproduce the issue.

I made a virtualenv with py34.

mkvirtualenv -p /usr/local/bin/python3.4 test-multi
python setup.py install
pip install tox
tox -e py34

Key points from the log output that it mentions in the error...

Command "/Users/me/Documents/google/gcloud-python/.tox/py34/bin/python3.4 -u -c "import setuptools, tokenize;__file__='/private/var/folders/bc/htqxjjns6gv4g1kspb2zppm80000gn/T/pip-build-
bifiqtz2/grpcio/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" install --record /var/folders/bc/htqxjjns6gv4g1kspb2zppm80000gn/T/pip-ndumdegl-
record/install-record.txt --single-version-externally-managed --compile --install-headers /Users/me/Documents/google/gcloud-python/.tox/py34/bin/../include/site/python3.4/grpcio" failed with error code 1 in /private/var/folders/bc/htqxjjns6gv4g1kspb2zppm80000gn/T/pip-build-bifiqtz2/grpcio/

daspecster · 2016-07-13T23:31:36Z

@tseaver, should we just close this for now and hope that future grpc fixes it?

tseaver · 2016-07-13T23:41:54Z

@daspecster

Should we just close this for now and hope that future grpc fixes it?

I think we want to be where this PR is (the rationalize tox.ini, particularly). We need to have grpcio wheels published for Python 3.4+ (including Windows) before our story improves.

- Install 'grpcio' and related deps by default, and omit adding '_testing' to PYTHONPATH. - For Python 2.6, and lint, RTD, suppress installing gRPC-related deps, and add '_testing' to PYTHONPATH.

Also, pin GAX/GRPC libraries to avoid future breaking changes.

tseaver · 2016-07-21T21:34:20Z

@dhermes, @daspecster I rebased to fix conflicts, and also updated the version pins for the gRPC-related dependencies to reflect today's grpcio-1.0rc1 release, as well as comments from @bjwatson on potential future breaking changes for the GAX libraries.

tseaver · 2016-07-21T21:43:05Z

Woohoo! Travis is happy, at least for the PR.

Sign in to view

+ {[testing]deps}
 {[grpc]deps}
+
+[testenv:py26]


tseaver · 2016-07-22T16:34:59Z

@dhermes, @daspecster any remaining issues?

Sign in to view

- python2.7
+[docs]
+deps =
+ {[testenv]deps}


dhermes · 2016-07-22T16:41:27Z

LGTM

Sign in to view

+ 'gax-google-pubsub-v1 >= 0.7.12, < 0.8dev',
+ 'grpc-google-pubsub-v1 >= 0.7.12, < 0.8dev',
+ 'gax-google-logging-v2 >= 0.7.12, < 0.8dev',
+ 'grpc-google-logging-v2 >= 0.7.12, < 0.8dev',


Some google3 tests were failing due to timeouts. It seems like there were some tests that preformed up to 10 retries, with exponential backoff between each one This PR mocks out sleep, so these tests will complete ~ instantly, rather than > 10 mins --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

This updates tests to use `max_iterations` rather than `max_iteration` which was an alpha option. Related: b/344469351

* docs: add code snippet for storing dataframes to a CSV file * fix lint * fix more lint

…1943)" (#1952) This reverts commit a511e09e6924d2e8302af2eb4a602c6b9e5d2d72.

tseaver added testing packaging labels Jun 29, 2016

tseaver assigned daspecster and dhermes Jun 29, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 29, 2016

tseaver added 3 commits July 21, 2016 17:20

Clean up bytes-vs-text for GAX-on-Py3k.
77f7e82

Rationalize tox vs. gRPC:
4879fd8
- Install 'grpcio' and related deps by default, and omit adding '_testing' to PYTHONPATH. - For Python 2.6, and lint, RTD, suppress installing gRPC-related deps, and add '_testing' to PYTHONPATH.

Bump 'grpcio' minimum version to 1.0rc1
acaa3b2
Also, pin GAX/GRPC libraries to avoid future breaking changes.

daspecster reviewed Jul 21, 2016
View reviewed changes

Comment threadtox.ini
{[testing]deps}
{[grpc]deps}

[testenv:py26]
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

dhermes reviewed Jul 22, 2016
View reviewed changes

Comment threadtox.ini
python2.7
[docs]
deps =
{[testenv]deps}
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

bjwatson reviewed Jul 22, 2016
View reviewed changes

tseaver merged commit a609621 into googleapis:masterJul 22, 2016

tseaver deleted the grpc-except-py26-lint-rtd branch July 22, 2016 17:01

This was referenced Aug 3, 2016
Prepare 0.18.0 release #2044
Closed
Prepare 0.18.0 release. #2048
Merged

theacodes unassigned daspecster and dhermes Sep 28, 2018

parthea pushed a commit that referenced this pull request Mar 6, 2026
testing: update BQML training option (#1943)
5343a44
This updates tests to use `max_iterations` rather than `max_iteration` which was an alpha option. Related: b/344469351

parthea pushed a commit that referenced this pull request Apr 1, 2026
docs: add code snippet for storing dataframes to a CSV file (#1943)
a174357
* docs: add code snippet for storing dataframes to a CSV file * fix lint * fix more lint

parthea pushed a commit that referenced this pull request Apr 1, 2026
Revert "docs: add code snippet for storing dataframes to a CSV file (#…
4d178a2
…1943)" (#1952) This reverts commit a511e09e6924d2e8302af2eb4a602c6b9e5d2d72.

Uh oh!

Conversation

tseaver commented Jun 29, 2016

Uh oh!

tseaver commented Jun 29, 2016

Uh oh!

dhermes commented Jun 29, 2016

Uh oh!

tseaver commented Jun 29, 2016

Uh oh!

daspecster commented Jun 30, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daspecster commented Jul 13, 2016

Uh oh!

tseaver commented Jul 13, 2016

Uh oh!

tseaver commented Jul 21, 2016

Uh oh!

tseaver commented Jul 21, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Jul 22, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Jul 22, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

daspecster commented Jun 30, 2016•
edited
Loading