Re-enable bundling (for consideration)

[daspecster]

I know this is probably up for debate, I just wanted to learn more about this.
If you guys do want to re-enable this(#1911) I'll make whatever changes are needed!

Or let me know and I'll close this if you want to go in a different direction.

[tseaver]

@daspecster Can you try running the pubsub system tests on your branch with gRPC enabled? E.g.:

$ tox -e system-tests --notest
$ GCLOUD_ENABLE_GAX .tox/system-tests/bin/python \
system_tests/run_system_test.py --package=pubsub

[tseaver]

LGTM once Travis passes, assuming the system tests pass for you with gRPC/GAX enabled.

[daspecster]

I ran it with this...

GCLOUD_TESTS_PROJECT_ID=ferrous-arena GOOGLE_APPLICATION_CREDENTIALS=creds.json GCLOUD_ENABLE_GAX=True .tox/system-tests/bin/python system_tests/run_system_test.py --package=pubsub

[tseaver]

That spew at the end is gRPC whining: harmless, but annoying for our purposes. I won't tackle #1873 until it is resolved, though.

[tseaver]

LGTM

[tseaver]

@bjwatson Ugh, are you saying that the only change we needed was to set is_bundling=True in the CallOptions constructor?

[bjwatson]

I think so.

[daspecster]

@bjwatson, these are the only references to is_bundling in https://github.com/googleapis/gax-python/search?utf8=%E2%9C%93&q=is_bundling&type=Code.

I'm not sure how the discovery stuff works but, what/how would pick up on the is_bundling flag?

[bjwatson]

@daspecster The first reference is the one that does the magic: https://github.com/googleapis/gax-python/blob/75fc5bdbbad46ab1d08d30718ef1485ae211eb5b/google/gax/__init__.py#L134

It depends on bundling settings being configured for the method: https://github.com/googleapis/googleapis/blob/master/google/pubsub/v1/pubsub_gapic.yaml#L227

I'm not sure about Discovery. Are you doing anything with that? It's just generating file-length sample code right now, and not any API surfaces.

[daspecster]

@bjwatson, thanks!

I'm not sure on the Discovery question.
@tseaver, do you know?