Uh oh!
There was an error while loading. Please reload this page.
Making HappyBase enabled/disabled checks into no-ops. - #1997
Merged
Conversation
tseaver
commented
Jul 19, 2016
Contributor
LGTM pending Travis. |
dhermes
commented
Jul 19, 2016
ContributorAuthor
mbrukman
commented
Jul 19, 2016
Contributor
LGTM Are there any concerns about non-actionable warning messages, since there's nothing a user can do to remove the warnings, short of not calling the functions? I guess since these actions are administrative rather than data-oriented, they should be called rather rarely, so it shouldn't clog up their logs too much, and they ought to know that they're no-ops, so I think this is fine. Thanks for making the change! |
Also fixing some lint related errors (not using arguments and not using self).
dhermes
commented
Jul 19, 2016
ContributorAuthor
tseaver
commented
Jul 19, 2016
Contributor
LGTM |
dhermes
commented
Jul 19, 2016
ContributorAuthor
@mbrukman Implemented your updates to the language. |
mbrukman
commented
Jul 19, 2016
Contributor
LGTM, thanks! |
This was referenced Aug 3, 2016
Closed
parthea added a commit
that referenced
this pull request
Nov 24, 2025
parthea pushed a commit
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#1989.
/cc @mbrukman@tswast