Change [pep8]-> [pycodestyle] in tox.ini

[daspecster]

Here's an example of what I was talking about in #2019 (comment).

pycodestyle reference: PyCQA/pycodestyle#550

[daspecster]

I deleted the cache on travis for this PR too. No dice.

[dhermes]

Is there documentation to support either syntax?

[daspecster]

From: http://pep8.readthedocs.io/en/latest/intro.html#configuration

Travis says it's pulling in pycodestyle=2.0.0 AFAICT.

[dhermes]

👍

[daspecster]

pycodestyle still hasn't cut a release yet.

[dhermes]

Refresh me, what is the release we're waiting for

[daspecster]

Supporting [pycodestyle] in the config instead of [pep8].

On Wed, Aug 17, 2016 at 2:30 PM, Danny Hermes notifications@github.com
wrote:

Refresh me, what is the release we're waiting for

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2020 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALvyKLNTlabyMiswmQILZLb-6OAr05Kks5qg1MqgaJpZM4JTL4U
.

Tom Schultz

[dhermes]

Ah. Shucks.

[daspecster]

Should get a release for this soon! PyCQA/pycodestyle#574 (comment)

[tseaver]

Ugh, THAT NO WORK!

[daspecster]

@tseaver, Yeah not until they cut the release. They updated on their master branch a while ago but that change hasn't been pushed to pypi.

When they cut the release I'll start travis and it should just go green.

[daspecster]

Pycodestyle 2.1.0!
https://github.com/PyCQA/pycodestyle/releases/tag/2.1.0

[dhermes]

@daspecster You need a version lower bound: https://github.com/GoogleCloudPlatform/google-cloud-python/blob/75e46139695747ddd1bbbc8cd3841bb6897331c8/tox.ini#L214

[daspecster]

@dhermesb8d6ed6

[dhermes]

LGTM pending Travis

[dhermes]

Actually @daspecster it looks like the new version of pycodestyle picked up something it didn't before:

scripts/generate_json_docs.py:656:1: E305 expected 2 blank lines after class or function definition, found 1

Can you add an extra empty line before the if __name__ == '__main__' in that file?

[dhermes]

@daspecster LGTM to merge on Travis green. Also, is the don't merge label still relevant?

[daspecster]

Ok cool. Nope, forgot it was there.