Skip to content

Fix doc line linking - #2025

Merged
daspecster merged 6 commits into
googleapis:masterfrom
daspecster:fix-doc-line-linking
Jul 29, 2016
Merged

Fix doc line linking#2025
daspecster merged 6 commits into
googleapis:masterfrom
daspecster:fix-doc-line-linking

Conversation

@daspecster

@daspecsterdaspecster commented Jul 26, 2016

Copy link
Copy Markdown
Contributor

Fixes#2024 and adds Error Reporting module.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 26, 2016
tseaver
tseaver reviewed Jul 26, 2016
View reviewed changes
Comment threadscripts/generate_json_docs.py
source_path = source.replace(path, '')

return source_path[1:]
return source_path

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@daspecster

daspecster commented Jul 26, 2016

Copy link
Copy Markdown
ContributorAuthor

@tseaver there we go. LMKWYT!

tseaver
tseaver reviewed Jul 26, 2016
View reviewed changes
Comment threadscripts/generate_json_docs.py
ABSOLUTE_LIBRARY_PATH = '/'.join(os.path.abspath(gcloud.__file__)
.split('/')[:-2])


This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@daspecster
daspecsterforce-pushed the fix-doc-line-linking branch from 3055ed3 to 6bbe052CompareJuly 26, 2016 17:30
daspecster
daspecster reviewed Jul 26, 2016
View reviewed changes
Comment threadscripts/generate_json_docs.py Outdated
if 'gcloud-python' in source:
source_path = source.split('gcloud-python')[1]
if ABSOLUTE_LIBRARY_PATH in source:
source_path = source.replace(ABSOLUTE_LIBRARY_PATH, '')

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver

tseaver commented Jul 28, 2016

Copy link
Copy Markdown
Contributor

The test fix is my bad: I introduced the test failure while merging / fixing up #2029. I restarted Travis after pushing my fix.

@tseaver

tseaver commented Jul 28, 2016

Copy link
Copy Markdown
Contributor

LGTM

@daspecster
daspecster merged commit c0e4e37 into googleapis:masterJul 29, 2016
@daspecster
daspecster deleted the fix-doc-line-linking branch July 29, 2016 13:37
This was referenced Aug 3, 2016
Closed
Merged
parthea pushed a commit that referenced this pull request Mar 6, 2026
@renovate-bot@gcf-owl-bot
chore(deps): update all dependencies (#2025)
e1482d4
* chore(deps): update all dependencies
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
@jialuoo
test: Add unit test for get_hash (#2025)
665cff7
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tseavertseaver

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@daspecster@tseaver@dhermes@googlebot