Uh oh!
There was an error while loading. Please reload this page.
Update the helper _datetime_to_rfc3339 to handle time zones. - #2041
Merged
Conversation
The helper function _format_timestamp in gcloud.monitoring.query is superseded by this updated helper function.
| :rtype: str | ||
| :returns: The string representing the datetime stamp. | ||
| """ | ||
| if not(ignore_zone or value.tzinfo is None): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
dhermes
commented
Aug 1, 2016
Contributor
Mostly LGTM other than the nit about the Thanks a lot for doing this! |
dhermes
commented
Aug 1, 2016
Contributor
LGTM once Travis passes |
This was referenced Aug 3, 2016
Closed
parthea added a commit
that referenced
this pull request
Nov 24, 2025
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit
that referenced
this pull request
Mar 6, 2026
* Migrate to pyproject.toml * Update * Add copyright notice * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update pyproject.toml --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
parthea pushed a commit
that referenced
this pull request
Apr 1, 2026
* test: Add unit test for get_python_version * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The helper function _format_timestamp in gcloud.monitoring.query is
superseded by this updated helper function.