Skip to content

Drop support for Python 2.6. - #2051

Merged
tseaver merged 6 commits into
googleapis:masterfrom
tseaver:drop-py26
Aug 4, 2016
Merged

Drop support for Python 2.6.#2051
tseaver merged 6 commits into
googleapis:masterfrom
tseaver:drop-py26

Conversation

@tseaver

@tseavertseaver commented Aug 3, 2016

Copy link
Copy Markdown
Contributor

Closes#1607.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 3, 2016
@dhermes

dhermes commented Aug 3, 2016

Copy link
Copy Markdown
Contributor

I'm grep-ing around for some other things worth cleaning up:

CONTRIBUTING.rst:- The feature must work fully on the following CPython versions: 2.6,
CONTRIBUTING.rst:- `Python 2.6`_
CONTRIBUTING.rst:.. _Python 2.6: https://docs.python.org/2.6/
CONTRIBUTING.rst:We may `drop 2.6`_ as a supported version as well since Python 2.6 is no
CONTRIBUTING.rst:.. _drop 2.6: https://github.com/GoogleCloudPlatform/gcloud-python/issues/995
gcloud/_helpers.py:363: if sys.version_info[:2] < (2, 7): # pragma: NO COVER Python 2.6
gcloud/exceptions.py:40: # suppress deprecation warning under 2.6.x
gcloud/error_reporting/client.py:174: # once py26 support is dropped this can use dict comprehension

@tseaver

tseaver commented Aug 4, 2016

Copy link
Copy Markdown
ContributorAuthor

@dhermes Should be addressed in subsequent commits.

@tseaver
Drop Python 2.6 helper function.
5edab4b
'gcloud._helpers._total_seconds' worked around the fact that
'datetime.timedelta.total_seconds' was not added until Python 2.7.
@tseaver
Drop Python 2.6 workaround.
8f84ea0
@tseaver
Use a dict comprehension.
d8aa805
@tseaver

tseaver commented Aug 4, 2016

Copy link
Copy Markdown
ContributorAuthor

Amended to fix the lint issue.

dhermes
dhermes reviewed Aug 4, 2016
View reviewed changes
Comment threadgcloud/exceptions.py
super(GCloudError, self).__init__()
# suppress deprecation warning under 2.6.x
super(GCloudError, self).__init__(message)
self.message = message

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes

dhermes commented Aug 4, 2016

Copy link
Copy Markdown
Contributor

Only question left: do we want to add a warning on import?

@tseaver

tseaver commented Aug 4, 2016

Copy link
Copy Markdown
ContributorAuthor

Do we want to add a warning on import?

I think not on import: maybe on installation. @daspecster, @jgeewax WDYT?

@dhermes

dhermes commented Aug 4, 2016

Copy link
Copy Markdown
Contributor

OK let's just merge (LGTM) and file an issue to follow up / decide if we should warn on either import or installation.

@tseaver
tseaver merged commit 3328a5c into googleapis:masterAug 4, 2016
@tseaver
tseaver deleted the drop-py26 branch August 4, 2016 18:15
@tseavertseaver mentioned this pull request Aug 4, 2016
Closed
@tseaver

tseaver commented Aug 4, 2016

Copy link
Copy Markdown
ContributorAuthor

See also #2056.

@dhermesdhermes mentioned this pull request Sep 19, 2016
Merged
parthea added a commit that referenced this pull request Nov 24, 2025
@achew22@vchudnov-g@parthea
fix: missing DEFAULT_HOST should still result in compiling code (#2051)
deda31b
Co-authored-by: Victor Chudnovsky <vchudnov@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Mar 6, 2026
@kien-truong@Linchin
feat: support setting max_stream_count when fetching query result (#2051
b59cbb8
)
* feat: support setting max_stream_count when fetching query result
Allow user to set max_stream_count when fetching result
using BigQuery Storage API with RowIterator's incremental methods:
* to_arrow_iterable
* to_dataframe_iterable
* docs: update docs about max_stream_count for ordered query
* fix: add max_stream_count params to _EmptyRowIterator's methods
* test: add tests for RowIterator's max_stream_count parameter
* docs: add notes on valid max_stream_count range in docstring
* use a different way to iterate result
---------
Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
@TrevorBergeron
fix: Fix issue mishandling chunked array while loading data (#2051)
0aedd87
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.packaging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver@dhermes@daspecster@googlebot