Skip to content

Re-enable GAX by default if it is importable. - #2085

Merged
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:reenable-gax-by-default
Aug 10, 2016
Merged

Re-enable GAX by default if it is importable.#2085
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:reenable-gax-by-default

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

As of the 0.8.1 versions of the wrappers, the pubsub and logging system tests pass on Python3.4 with GAX enabled.

As of the '0.8.1' versions of the wrappers, the pubsub and logging
system tests pass on Python3.4 with GAX enabled.
@tseavertseaver added api: pubsub Issues related to the Pub/Sub API. api: logging Issues related to the Cloud Logging API. grpc labels Aug 10, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 10, 2016
@dhermes

Copy link
Copy Markdown
Contributor

Do we need a docs change here?

@tseaver

Copy link
Copy Markdown
ContributorAuthor

Maybe so. We didn't previously document how to enable the GAX wrappers, as it was really a "developers only" option.

@tseaver

tseaver commented Aug 10, 2016

Copy link
Copy Markdown
ContributorAuthor

@dhermes Docs added in 9cf5b72. PTAL

@dhermes

Copy link
Copy Markdown
Contributor

LGTM

@tseaver
tseaver merged commit 27f0af5 into googleapis:masterAug 10, 2016
@tseaver
tseaver deleted the reenable-gax-by-default branch August 10, 2016 21:24
@dhermesdhermes mentioned this pull request Sep 19, 2016
parthea added a commit that referenced this pull request Nov 24, 2025
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
* fix: deflake ai_gen_bool multimodel test
* fix lint
* fix doctest too
* consolidates tests under system/small
* fix doctest
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: loggingIssues related to the Cloud Logging API.api: pubsubIssues related to the Pub/Sub API.cla: yesThis human has signed the Contributor License Agreement.grpc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver@dhermes@googlebot