Skip to content

logger_delete: map gRPC 'NOT_FOUND' error onto our 'NotFound' exception. - #2094

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:2091-logging-gax-logger-delete-raise-not-found
Aug 11, 2016
Merged

logger_delete: map gRPC 'NOT_FOUND' error onto our 'NotFound' exception.#2094
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:2091-logging-gax-logger-delete-raise-not-found

Conversation

@tseaver

@tseavertseaver commented Aug 11, 2016

Copy link
Copy Markdown
Contributor

Fixes#2091.

@tseavertseaver added the api: logging Issues related to the Cloud Logging API. label Aug 11, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 11, 2016
dhermes
dhermes reviewed Aug 11, 2016
View reviewed changes
Comment threadgcloud/logging/_gax.py
self._gax_api.delete_log(path, options)
except GaxError as exc:
if exc_to_code(exc.cause) == StatusCode.NOT_FOUND:
raise NotFound(path)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes

dhermes commented Aug 11, 2016

Copy link
Copy Markdown
Contributor

LGTM

@tseaver
tseaver merged commit a5bb176 into googleapis:masterAug 11, 2016
@tseaver
tseaver deleted the 2091-logging-gax-logger-delete-raise-not-found branch August 11, 2016 21:08
@dhermesdhermes mentioned this pull request Sep 19, 2016
Merged
parthea pushed a commit that referenced this pull request Mar 6, 2026
@dependabot
chore(deps): bump jinja2 from 3.1.4 to 3.1.5 in /.kokoro (#2094)
d8ce8c1
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.4 to 3.1.5.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst)
- [Commits](pallets/jinja@3.1.4...3.1.5)
---
updated-dependencies:
- dependency-name: jinja2
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
@TrevorBergeron
feat: Support df.info() with null index (#2094)
787175e
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: loggingIssues related to the Cloud Logging API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver@dhermes@googlebot