Uh oh!
There was an error while loading. Please reload this page.
Enable gRPC for datastore API. - #2099
Conversation
dhermes
commented
Aug 12, 2016
@tseaver I don't have a flag for disabling it, but am happy to add it, just wanted to here from you about it. |
| from gcloud.datastore._generated.datastore_pb2 import RollbackResponse | ||
| from gcloud.datastore._generated.datastore_pb2 import RunQueryRequest | ||
| from gcloud.datastore._generated.datastore_pb2 import RunQueryResponse | ||
| # END: Manually added imports |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
tseaver
commented
Aug 17, 2016
The environment flags for pubsub and logging were basically there to allow me to test with the gRPC team, without turning the feature on by default. We can probably leave them out here, if you don't feel paranoid about the gRPC stuff breaking us. |
dhermes
commented
Aug 17, 2016
I don't feel paranoid |
tseaver
commented
Aug 17, 2016
Hmm. |
dhermes
commented
Aug 17, 2016
Hmm aside, let's get #2097 settled and then move back here. (I'll resolve the merge conflict.) |
329b063 to
a820311Comparedhermes
commented
Aug 17, 2016
@tseaver Rebased after #2097, PTAL. The question remaining is how to update As for worry about gRPC, I was more saying I'm not worried about people having imports work but wanting to turn it off. And those people can just hack and edit the module-private |
tseaver
commented
Aug 17, 2016
This is the canonical case for |
dhermes
commented
Aug 17, 2016
Trying to avoid the |
a820311 to
cd9bc26Comparedhermes
commented
Aug 17, 2016
@tseaver Check out the latest commit |
| from grpc.beta import interfaces as beta_interfaces | ||
| from grpc.framework.common import cardinality | ||
| from grpc.framework.interfaces.face import utilities as face_utilities | ||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
tseaver
commented
Aug 18, 2016
LGTM |
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
NOTE: Has #2097 as diffbase.