Skip to content

Enable gRPC for datastore API. - #2099

Merged
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:datastore-add-grpc
Aug 18, 2016
Merged

Enable gRPC for datastore API.#2099
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:datastore-add-grpc

Conversation

@dhermes

@dhermesdhermes commented Aug 12, 2016

Copy link
Copy Markdown
Contributor

NOTE: Has #2097 as diffbase.

@dhermesdhermes added api: datastore Issues related to the Datastore API. grpc labels Aug 12, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2016
@dhermes

Copy link
Copy Markdown
ContributorAuthor

@tseaver I don't have a flag for disabling it, but am happy to add it, just wanted to here from you about it.

from gcloud.datastore._generated.datastore_pb2 import RollbackResponse
from gcloud.datastore._generated.datastore_pb2 import RunQueryRequest
from gcloud.datastore._generated.datastore_pb2 import RunQueryResponse
# END: Manually added imports

This comment was marked as spam.

This comment was marked as spam.

@tseaver

Copy link
Copy Markdown
Contributor

The environment flags for pubsub and logging were basically there to allow me to test with the gRPC team, without turning the feature on by default. We can probably leave them out here, if you don't feel paranoid about the gRPC stuff breaking us.

@dhermes

Copy link
Copy Markdown
ContributorAuthor

if you don't feel paranoid about the gRPC stuff breaking us

I don't feel paranoid

@tseaver

Copy link
Copy Markdown
Contributor

I don't feel paranoid

Hmm.

@dhermes

Copy link
Copy Markdown
ContributorAuthor

Hmm aside, let's get #2097 settled and then move back here. (I'll resolve the merge conflict.)

@dhermes

Copy link
Copy Markdown
ContributorAuthor

@tseaver Rebased after #2097, PTAL.

The question remaining is how to update make_operations_grpc.py to have all the imports. Should I just import all the names from gcloud.datastore._generated.datastore_pb2?


As for worry about gRPC, I was more saying I'm not worried about people having imports work but wanting to turn it off. And those people can just hack and edit the module-private _HAS_GRPC

@tseaver

Copy link
Copy Markdown
Contributor

The question remaining is how to update make_operations_grpc.py to have all the imports. Should I just import all the names from gcloud.datastore._generated.datastore_pb2?

This is the canonical case for from foo import *, even.

@dhermes

Copy link
Copy Markdown
ContributorAuthor

Trying to avoid the import *

@dhermes

Copy link
Copy Markdown
ContributorAuthor

@tseaver Check out the latest commit

from grpc.beta import interfaces as beta_interfaces
from grpc.framework.common import cardinality
from grpc.framework.interfaces.face import utilities as face_utilities

This comment was marked as spam.

This comment was marked as spam.

@tseaver

Copy link
Copy Markdown
Contributor

LGTM

@dhermes
dhermes merged commit a9891ab into googleapis:masterAug 18, 2016
@dhermes
dhermes deleted the datastore-add-grpc branch August 18, 2016 16:25
@dhermesdhermes mentioned this pull request Sep 19, 2016
parthea pushed a commit that referenced this pull request Apr 1, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastoreIssues related to the Datastore API.cla: yesThis human has signed the Contributor License Agreement.grpc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes@tseaver@googlebot