Skip to content

Wait even longer for orphan's topic to be None. - #2106

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:2080-wait-longer-for-orphan
Aug 16, 2016
Merged

Wait even longer for orphan's topic to be None.#2106
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:2080-wait-longer-for-orphan

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

Toward #2080.

@tseavertseaver added testing api: pubsub Issues related to the Pub/Sub API. flaky labels Aug 16, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 16, 2016
@tseaver

Copy link
Copy Markdown
ContributorAuthor

@daspecster, @dhermes I plan to merge this one-digit diff as soon as Travis is green, trying to get the build passing w/ both system test runs.

@daspecster

Copy link
Copy Markdown
Contributor

Instead of 8 tries would it work better to increase the wait time/delay? I'm just thinking of quotas but we probably have a really high quota for this.

@daspecster

Copy link
Copy Markdown
Contributor

Either way LGTM if it works for master! 🎉

@tseaver

Copy link
Copy Markdown
ContributorAuthor

@daspecster We aren't seeing quota-based failures: it just takes longer than expected for the deletion of the topic to show up when reloading the orphaned subscription.

@dhermes

Copy link
Copy Markdown
Contributor

LGTM as well

@tseaver
tseaver merged commit c805391 into googleapis:masterAug 16, 2016
@tseaver
tseaver deleted the 2080-wait-longer-for-orphan branch August 16, 2016 21:55
@dhermesdhermes mentioned this pull request Sep 19, 2016
parthea pushed a commit that referenced this pull request Apr 1, 2026
* feat: implement Index.to_list()
This commit implements the `Index.to_list()` method, which is an alias for `tolist()`. This new method provides a way to convert a BigQuery DataFrames Index to a Python list, similar to the existing `Series.to_list()` method.
The implementation follows the pattern of other methods in the library by first converting the Index to a pandas Index using `to_pandas()` and then calling the corresponding `.to_list()` method.
A unit test has been added to verify the functionality of the new method.
* Update bigframes/core/indexes/base.py
* Update tests/unit/test_index.py
---------
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsubIssues related to the Pub/Sub API.cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver@daspecster@dhermes@googlebot