Uh oh!
There was an error while loading. Please reload this page.
Removing usage of the gRPC beta subpackage. - #2149
Conversation
dhermes
commented
Aug 19, 2016
We'll also now need to update https://github.com/GoogleCloudPlatform/google-cloud-python-happybase |
dhermes
commented
Aug 19, 2016
@nathanielmanistaatgoogle It's also worth noting that GAX is still using the beta API /cc @bjwatson I realized that and had to modify |
bjwatson
commented
Aug 19, 2016
I created googleapis/gax-python#126 to track this. |
| from grpc.beta import implementations | ||
| from google.gax.grpc import exc_to_code as beta_exc_to_code | ||
| import grpc | ||
| from grpc._channel import _Rendezvous |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Also fixing a test mock failure for gcloud._helpers.
| def __exit__(self, exc_type, exc_val, exc_t): | ||
| """Stops the client as a context manager.""" | ||
| self.stop() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
tseaver
commented
Aug 22, 2016
Did we ditch the timeouts because the GA API no longer supports them? I like the simplicity on our side, but worry that users might still need them. |
tseaver
commented
Aug 22, 2016
LGTM |
Fixes#2130.
Most noteworthy is that the "stable" gRPC doesn't have
__exit__and__enter__and that the stubs are actual classes (instead of some instance of a private and esoteric class).When scanning for the case-insenstive string grpc I also found some things to change in other parts of the codebase I came across (e.g. a virtualenv root path falling back to
protoc)@nathanielmanistaatgoogle PTAL
In particular we went from the public exception type
grpc.framework.interfaces.face.face.AbortionErrorto the privategrpc._channel._Rendezvous.How are we or users supposed to build in error handling? Should we catch
grpc.Error(which_Rendezvousinherits from)?BIG WORRY: Every system tests finishes with