Skip to content

Adding 429 retry in storage for bucket create and delete. - #2161

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:rate-limit-storage-buckets
Aug 23, 2016
Merged

Adding 429 retry in storage for bucket create and delete.#2161
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:rate-limit-storage-buckets

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

Showed up when Travis when 3 merge builds right on top of each other:

https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/154249353
https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/154251510

@tseaver I am trying to force the failure locally so I can see more fine-grained error info but 429 is pretty specific so I'm not that worried. I also would like to add a debug flag so we get more error info in our failure messages on Travis.

@dhermesdhermes added api: storage Issues related to the Cloud Storage API. flaky labels Aug 22, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 22, 2016
@dhermes

Copy link
Copy Markdown
ContributorAuthor
(Pdb) print(content)
{
"error": {
"errors": [
{
"domain": "usageLimits",
"reason": "rateLimitExceeded",
"message": "The project exceeded the rate limit for creating and deleting buckets."
}
],
"code": 429,
"message": "The project exceeded the rate limit for creating and deleting buckets."
}
}
(Pdb) print(json.dumps(response, indent=2))
{
"status": "429", "alternate-protocol": "443:quic", "content-length": "301", "x-xss-protection": "1; mode=block", "x-content-type-options": "nosniff", "transfer-encoding": "chunked", "expires": "Mon, 22 Aug 2016 21:10:37 GMT", "vary": "Origin, X-Origin", "server": "GSE", "-content-encoding": "gzip", "cache-control": "private, max-age=0", "date": "Mon, 22 Aug 2016 21:10:37 GMT", "x-frame-options": "SAMEORIGIN", "alt-svc": "quic=\":443\"; ma=2592000; v=\"35,34,33,32,31,30\"", "content-type": "application/json; charset=UTF-8"
}
(Pdb) exc=make_exception(response, content, error_info=method+' '+url)
(Pdb) print(json.dumps(exc.errors, indent=2))
[
{
"reason": "rateLimitExceeded", "domain": "usageLimits", "message": "The project exceeded the rate limit for creating and deleting buckets."
}
]

@tseaver

Copy link
Copy Markdown
Contributor

pylint is unhappy.

@tseaver

Copy link
Copy Markdown
Contributor

LGTM once pylint is appeased.

@dhermes
dhermesforce-pushed the rate-limit-storage-buckets branch from bf34b44 to ca74a4aCompareAugust 23, 2016 00:37
@dhermes
dhermes merged commit 0a3b42e into googleapis:masterAug 23, 2016
@dhermes
dhermes deleted the rate-limit-storage-buckets branch August 23, 2016 01:33
@dhermesdhermes mentioned this pull request Sep 19, 2016
atulep pushed a commit that referenced this pull request Apr 6, 2023
…… [(#2161)](GoogleCloudPlatform/python-docs-samples#2161)
* adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request
* fixed some travis ci lint issues
* fixed some travis ci lint issues
* fixed some travis ci lint issues
* fixed some travis ci lint issues
atulep pushed a commit that referenced this pull request Apr 6, 2023
…… [(#2161)](GoogleCloudPlatform/python-docs-samples#2161)
* adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request
* fixed some travis ci lint issues
* fixed some travis ci lint issues
* fixed some travis ci lint issues
* fixed some travis ci lint issues
atulep pushed a commit that referenced this pull request Apr 18, 2023
…… [(#2161)](GoogleCloudPlatform/python-docs-samples#2161)
* adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request
* fixed some travis ci lint issues
* fixed some travis ci lint issues
* fixed some travis ci lint issues
* fixed some travis ci lint issues
parthea pushed a commit that referenced this pull request Oct 22, 2023
…… [(#2161)](GoogleCloudPlatform/python-docs-samples#2161)
* adding infinite streaming sample to samples folder, unlike indefinite streaming, this sample uses result_end_time to calculate unfinalized audio, and to resend it to maintain context across into the next streaming request
* fixed some travis ci lint issues
* fixed some travis ci lint issues
* fixed some travis ci lint issues
* fixed some travis ci lint issues
parthea pushed a commit that referenced this pull request Apr 1, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storageIssues related to the Cloud Storage API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes@tseaver@daspecster@googlebot