Skip to content

Implement Document factory constructors on language client - #2164

Merged
dhermes merged 5 commits into
googleapis:masterfrom
dhermes:language-impl-2
Aug 23, 2016
Merged

Implement Document factory constructors on language client#2164
dhermes merged 5 commits into
googleapis:masterfrom
dhermes:language-impl-2

Conversation

@dhermes

@dhermesdhermes commented Aug 22, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

NOTE: Has #2162 as diffbase.

@tseaver and @jgeewax this PR (namely the last 4 commits) make the discussion in #2062 / earlier today more concrete. Is this what you had in mind?

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 22, 2016
@dhermes
dhermesforce-pushed the language-impl-2 branch 2 times, most recently from 9267a85 to 009833bCompareAugust 22, 2016 22:22
tseaver
tseaver reviewed Aug 22, 2016
View reviewed changes
Comment threadgcloud/language/document.py Outdated

:type gcs_url: str
:param gcs_url: (Optional) The URL of the Google Cloud Storage object
holding the content.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver

tseaver commented Aug 22, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

I thought document_from_url was less useful than document_from_blob -- maybe I misunderstood? Again, I see you outpace me. :)

@dhermes
dhermesforce-pushed the language-impl-2 branch 3 times, most recently from ebb6c83 to a0ef4c9CompareAugust 23, 2016 01:35
@tseaver

tseaver commented Aug 23, 2016

Copy link
Copy Markdown
Contributor

@dhermes To fix the json-docs error, add language to the mapping in scripts/generate_json_docs.py:main.

@dhermes

dhermes commented Aug 23, 2016

Copy link
Copy Markdown
ContributorAuthor

@tseaver Any issues? Any other factories needed?

tseaver
tseaver reviewed Aug 23, 2016
View reviewed changes
Comment threaddocs/language-usage.rst
>>> document = client.document_from_blob(bucket='my-text-bucket',
... blob='sentiment-me.txt')
>>> document = client.document_from_blob('my-text-bucket',
... 'sentiment-me.txt')

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermesdhermes mentioned this pull request Aug 23, 2016
Merged
@dhermes

dhermes commented Aug 23, 2016

Copy link
Copy Markdown
ContributorAuthor

@tseaver Where do we stand on getting this merged? Do we want the document_from_blob() constructor? Should it behave differently? Should I punt on those factories for another PR?

@tseaver

tseaver commented Aug 23, 2016

Copy link
Copy Markdown
Contributor

I guess leave document_from_blob as is for now, and consider using the Blob class is an enhancement like #2127.

@dhermes

dhermes commented Aug 23, 2016

Copy link
Copy Markdown
ContributorAuthor

Filed #2173

@dhermes

dhermes commented Aug 23, 2016

Copy link
Copy Markdown
ContributorAuthor

@tseaver LGTY otherwise?

@tseaver

tseaver commented Aug 23, 2016

Copy link
Copy Markdown
Contributor

LGTM

@dhermes
dhermes merged commit 9b3a082 into googleapis:masterAug 23, 2016
@dhermes
dhermes deleted the language-impl-2 branch August 23, 2016 20:12
@dhermesdhermes mentioned this pull request Sep 19, 2016
Merged
parthea added a commit that referenced this pull request Nov 24, 2025
@ohmayr@parthea
feat: add async rest transport support in gapics (#2164)
a42469e
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Mar 6, 2026
@gcf-owl-bot@parthea@chalmerlowe
chore(python): remove docs from templates (#2164)
9af1f75
* chore(python): remove docs from templates
Source-Link: googleapis/synthtool@3fca64a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3b3a31be60853477bc39ed8d9bac162cac3ba083724cecaad54eb81d4e4dae9c
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* remove replacement in owlbot.py
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
@chelsea-lin
refactor: add agg_ops.TimeSeriesDiffOp and DateSeriesDiffOp to sqlglo…
1bd8dee
…t compiler (#2164)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tseavertseaver

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dhermes@tseaver@jgeewax@daspecster@googlebot