Skip to content

Remove old docsite app files so it doesn't overwrite on deploy - #2178

Merged
daspecster merged 2 commits into
googleapis:masterfrom
daspecster:remove-old-doc-site-files
Aug 24, 2016
Merged

Remove old docsite app files so it doesn't overwrite on deploy#2178
daspecster merged 2 commits into
googleapis:masterfrom
daspecster:remove-old-doc-site-files

Conversation

@daspecster

@daspecsterdaspecster commented Aug 24, 2016

Copy link
Copy Markdown
Contributor

We're accepting docsite updates from gcloud-common now.
Anytime there is an update for the site committed to gcloud-common, their deploy-docs.sh file is run and updates the listed repos.

These files were being copied and overwriting the latest app files that were getting pushed by gcloud-common.

@daspecsterdaspecster added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. docs labels Aug 24, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2016
@daspecster

Copy link
Copy Markdown
ContributorAuthor

@callmehiphop can we force run deploy-docs.sh after this is merged to get the latest again from gcloud-common/site?

@callmehiphop

Copy link
Copy Markdown

Not sure, would restarting an older Travis job do the trick?

@daspecster

Copy link
Copy Markdown
ContributorAuthor

That's what I was going to do, but I thought I'd ask just to make sure.

@dhermes

Copy link
Copy Markdown
Contributor
  1. LGTM
  2. Why not just run the script locally?
  3. Can any of the other files go? e.g. the JSON files

@daspecster

Copy link
Copy Markdown
ContributorAuthor
  1. 🎉
  2. Good idea!
  3. I'm updating to remove extra html files. I think the rest is required?

@callmehiphop can you confirm that all we need is home.html in the json dir?

@callmehiphop

Copy link
Copy Markdown

@daspecster Yep!

@daspecster
daspecster merged commit cf59650 into googleapis:masterAug 24, 2016
@daspecster

Copy link
Copy Markdown
ContributorAuthor

Looks like it all worked! The top nav is working and the side nav collapsed appropriately.

@dhermesdhermes mentioned this pull request Sep 19, 2016
@daspecster
daspecster deleted the remove-old-doc-site-files branch January 24, 2017 15:18
parthea pushed a commit that referenced this pull request Mar 6, 2026
Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@daspecster@callmehiphop@dhermes@googlebot