Skip to content

Retry on 500 from 'descriptor.{create,delete}'. - #2197

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:2176-monitoring-500-on-descriptor-delete
Aug 25, 2016
Merged

Retry on 500 from 'descriptor.{create,delete}'.#2197
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:2176-monitoring-500-on-descriptor-delete

Conversation

@tseaver

@tseavertseaver commented Aug 25, 2016

Copy link
Copy Markdown
Contributor

Toward #2176.

@tseavertseaver added api: monitoring Issues related to the Cloud Monitoring API. flaky labels Aug 25, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 25, 2016
dhermes
dhermes reviewed Aug 25, 2016
View reviewed changes
Comment threadsystem_tests/monitoring.py Outdated
from system_test_utils import unique_resource_id

retry_404 = RetryErrors(NotFound)
retry_404_500 = RetryErrors(NotFound, InternalServerError)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseavertseaver changed the title Retry on 500 from 'descriptor.delete'.Retry on 500 from 'descriptor.{create,delete}'.Aug 25, 2016
@tseaver

tseaver commented Aug 25, 2016

Copy link
Copy Markdown
ContributorAuthor

@dhermes I just updated the commit to wrap a retry_500 around the descriptor.create. PTAL

@daspecster

daspecster commented Aug 25, 2016

Copy link
Copy Markdown
Contributor

LGTM, although I don't get why it's ok to throw a 500.
Is there a way that we can remember to undo this once the upstream service starts becoming more reliable?

@tseaver

tseaver commented Aug 25, 2016

Copy link
Copy Markdown
ContributorAuthor

@daspecster How will we ever know: that is a "Schroedinger's Cat" problem.

@tseaver
tseaver merged commit 5896dd3 into googleapis:masterAug 25, 2016
@tseaver
tseaver deleted the 2176-monitoring-500-on-descriptor-delete branch August 25, 2016 21:21
@tseavertseaver mentioned this pull request Aug 26, 2016
Merged
@dhermesdhermes mentioned this pull request Sep 19, 2016
Merged
parthea pushed a commit that referenced this pull request Mar 6, 2026
@chalmerlowe
ddocs: fixes several typos and updates a try except block (#2197)
6b0ac34
parthea pushed a commit that referenced this pull request Apr 1, 2026
@chelsea-lin
refactor: add struct_op and sql_scalar_op for the sqlglot compiler (#…
2e7da69
…2197)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: monitoringIssues related to the Cloud Monitoring API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver@daspecster@dhermes@googlebot