Skip to content

Use lower-case gRPC header keys - #2212

Merged
tseaver merged 2 commits into
googleapis:masterfrom
yang-g:master
Aug 27, 2016
Merged

Use lower-case gRPC header keys#2212
tseaver merged 2 commits into
googleapis:masterfrom
yang-g:master

Conversation

@yang-g

Copy link
Copy Markdown
Contributor

As upper-case letters are illegal per http2 spec.

As upper-case letters are illegal per http2 spec.
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 26, 2016
@yang-g

Copy link
Copy Markdown
ContributorAuthor

#2204

@tseaver

Copy link
Copy Markdown
Contributor

@yang-g Thanks for the fix! Travis is going to barf whenever it gets around to running, because the unit tests assert the upper-case field names:

======================================================================FAIL: test___call__ (gcloud.test__helpers.TestMetadataPlugin)
----------------------------------------------------------------------Traceback (mostrecentcalllast):
File"/home/tseaver/projects/agendaless/Google/src/gcloud-python/gcloud/test__helpers.py", line845, intest___call__self.assertEqual(callback_args, [(cb_headers, None)])
AssertionError: Listsdiffer: [([('authorization', 'Bearer F... != [([('Authorization', 'BearerF...
Firstdifferingelement0:
([('authorization', 'Bearer FOOBARBAZ'), ('user-agent', 'USER_AGENT')], None)
([('Authorization', 'Bearer FOOBARBAZ'), ('User-agent', 'USER_AGENT')], None)
- [([('authorization', 'Bearer FOOBARBAZ'), ('user-agent', 'USER_AGENT')], None)]
? ^^+ [([('Authorization', 'Bearer FOOBARBAZ'), ('User-agent', 'USER_AGENT')], None)]
? ^^

Can you please update the PR accordingly?

@dhermes, @daspecster For future reference, here is the HTTP/2 spec reference which mandates lower-case for header field names (I was completely unaware of that requirement).

@tseaver

Copy link
Copy Markdown
Contributor

I cancelled the not-yet-started Travis build after verifying that it would fail.

@yang-g

Copy link
Copy Markdown
ContributorAuthor

@tseaver I pushed eebb83a about the same time of your comment. I did a search and did not find anything else. Could you restart the travis-ci or point me to more places to fix? Thanks.

@tseaver

Copy link
Copy Markdown
Contributor

@yang-g I restarted the build. Sorry for my haste in cancelling -- Travis has been so glacially slow lately that we've been minimizing "known broken" jobs in the queue.

@dhermes

Copy link
Copy Markdown
Contributor

@tseaver I think Travis have sorted out their issues

@tseaver
tseaver merged commit a5594a7 into googleapis:masterAug 27, 2016
@tseaver

Copy link
Copy Markdown
Contributor

@yang-g Thank you again!

@dhermesdhermes mentioned this pull request Sep 19, 2016
parthea pushed a commit that referenced this pull request Mar 6, 2026
* test: remove pragma
* test: remove comment about pragma
* updates to conditionals related to pandas 2.0+ tests
parthea pushed a commit that referenced this pull request Apr 1, 2026
* fix: simplify UnsupportedTypeError message
* relax assertion
parthea pushed a commit that referenced this pull request Apr 1, 2026
🤖 I have created a release *beep* *boop*
---
##
[2.29.0](google/bigframes@v2.28.0...v2.29.0)
(2025-11-10)
### Features
* Add bigframes.bigquery.st_regionstats to join raster data from Earth
Engine
([#2228](google/bigframes#2228))
([10ec52f](google/bigframes@10ec52f))
* Add DataFrame.resample and Series.resample
([#2213](google/bigframes#2213))
([c9ca02c](google/bigframes@c9ca02c))
* SQL Cell no longer escapes formatted string values
([#2245](google/bigframes#2245))
([d2d38f9](google/bigframes@d2d38f9))
* Support left_index and right_index for merge
([#2220](google/bigframes#2220))
([da9ba26](google/bigframes@da9ba26))
### Bug Fixes
* Correctly iterate over null struct values in ManagedArrowTable
([#2209](google/bigframes#2209))
([12e04d5](google/bigframes@12e04d5))
* Simplify UnsupportedTypeError message
([#2212](google/bigframes#2212))
([6c9a18d](google/bigframes@6c9a18d))
* Support results with STRUCT and ARRAY columns containing JSON
subfields in `to_pandas_batches()`
([#2216](google/bigframes#2216))
([3d8b17f](google/bigframes@3d8b17f))
### Documentation
* Switch API reference docs to pydata theme
([#2237](google/bigframes#2237))
([9b86dcf](google/bigframes@9b86dcf))
* Update notebook for JSON subfields support in to_pandas_batches()
([#2138](google/bigframes#2138))
([5663d2a](google/bigframes@5663d2a))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.grpc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@yang-g@tseaver@dhermes@googlebot