Skip to content

Add retry for flaky 'topic.exists()' check. - #2214

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:2111-pubsub-topic-exists-unavailable
Aug 29, 2016
Merged

Add retry for flaky 'topic.exists()' check.#2214
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:2111-pubsub-topic-exists-unavailable

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

Toward #2111.

@tseavertseaver added api: pubsub Issues related to the Pub/Sub API. flaky labels Aug 28, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2016
@daspecster

Copy link
Copy Markdown
Contributor

LGTM, might as well give it a try?

@tseaver
tseaver merged commit e8c064b into googleapis:masterAug 29, 2016
@tseaver
tseaver deleted the 2111-pubsub-topic-exists-unavailable branch August 29, 2016 02:05
@tseaver

Copy link
Copy Markdown
ContributorAuthor

@daspecster

Copy link
Copy Markdown
Contributor

Isn't that handled in the #2215 PR though?

@tseaver

Copy link
Copy Markdown
ContributorAuthor

@daspecster#2214 is about the test_fetch_delete_subscription_w_deleted_topic failure: this PR is supposed to fix the test_list_subscriptions testcase.

@daspecster

Copy link
Copy Markdown
Contributor

Oh sorry, my browser started at the bottom line that you linked so I didn't even notice it. Silly chrome.

@dhermesdhermes mentioned this pull request Sep 19, 2016
parthea pushed a commit that referenced this pull request Apr 1, 2026
* refactor: rename _apply_unary_ops to _apply_ops_to_sql
* fix lint
* fix mypy
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsubIssues related to the Pub/Sub API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver@daspecster@dhermes@googlebot