Skip to content

Switching from nosetests to py.test. - #2241

Merged
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:use-pytest
Sep 3, 2016
Merged

Switching from nosetests to py.test.#2241
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:use-pytest

Conversation

@dhermes

@dhermesdhermes commented Sep 2, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 2, 2016
@dhermes

dhermes commented Sep 2, 2016

Copy link
Copy Markdown
ContributorAuthor

I also created https://github.com/GoogleCloudPlatform/gcloud-python/tree/use-pytest to spawn https://ci.appveyor.com/project/dhermes/gcloud-python/build/1.0.617.use-pytest

Will delete after this is verified.

daspecster
daspecster reviewed Sep 2, 2016
View reviewed changes
Comment threadsetup.cfg
@@ -1,2 +0,0 @@
[nosetests]
exclude-dir = system_tests

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
dhermesforce-pushed the use-pytest branch 3 times, most recently from 26626a2 to 19df78bCompareSeptember 2, 2016 21:04
dhermes
dhermes reviewed Sep 2, 2016
View reviewed changes
Comment threadtox.ini Outdated
commands =
{[testing]covercmd} --cover-min-percentage=100
{[testing]covercmd}
coverage report --show-missing --fail-under=100

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Adding tox support for AppVeyor.
0a7bd23
In the process, fixing some PATH issues in "gcloud._helpers"
(path separator was explicitly provided, rather than using
"os.join"). Also the the associated tests were refactored
with more mocks so that they depend less on the OS.
@dhermes

dhermes commented Sep 2, 2016

Copy link
Copy Markdown
ContributorAuthor

The continuous-integration/travis-ci/push check came up because I pushed theGoogleCloudPlatform/gcloud-python:use-pytest branch to this project. (I did it so that the AppVeyor tests would spawn, mentioned above.)

That job didn't fail, I just canceled it, since it would be repetetive to run both PUSH/PR for the same exact code.

This should be ready to merge if I can get an LGTM.

@theacodes

theacodes commented Sep 3, 2016

Copy link
Copy Markdown
Contributor

Lgtm

On Fri, Sep 2, 2016, 4:49 PM Danny Hermes notifications@github.com wrote:

The continuous-integration/travis-ci/push check came up because I pushed
theGoogleCloudPlatform/gcloud-python:use-pytest branch to this project.
(I did it so that the AppVeyor tests would spawn, mentioned above.)

That job didn't fail, I just canceled it, since it would be repetetive to
run both PUSH/PR for the same exact code.

This should be ready to merge if I can get an LGTM.

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#2241 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUczhDUyiQmLqvqj2h4ZD2C7wdYa8bks5qmLXugaJpZM4Jz_YD
.

@dhermes
dhermes merged commit d586990 into googleapis:masterSep 3, 2016
@dhermes
dhermes deleted the use-pytest branch September 3, 2016 00:18
@dhermesdhermes mentioned this pull request Sep 19, 2016
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tseavertseaver

@theacodestheacodes

Labels

cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dhermes@theacodes@daspecster@tseaver@googlebot