Skip to content

Fix logging/pubub system tests - #2260

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:pubsub-logging-post-2223-system-tests
Sep 7, 2016
Merged

Fix logging/pubub system tests#2260
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:pubsub-logging-post-2223-system-tests

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

Broken after #2223.

  • Namespace packages break use of 'Client' from package.
  • Shorten bucket / topic names to match limits.
  • Stop sharing sink / metric names across tests (brush clearing to find the real issue with bucket / topic names).

- Namespace packages break use of 'Client' from package.
- Shorten bucket / topic names to match limits.
- Stop sharing sink / metric names across tests.
@tseavertseaver added testing api: pubsub Issues related to the Pub/Sub API. api: logging Issues related to the Cloud Logging API. labels Sep 7, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 7, 2016
@daspecster

Copy link
Copy Markdown
Contributor

LGTM pending travis!

@tseaver

Copy link
Copy Markdown
ContributorAuthor

Travis will pass for the PR (only changes to system_tests/), but fail on merge (due to other #2259 issues).

@tseaver
tseaver merged commit 2499735 into googleapis:masterSep 7, 2016
@tseaver
tseaver deleted the pubsub-logging-post-2223-system-tests branch September 7, 2016 18:38
@dhermesdhermes mentioned this pull request Sep 19, 2016
parthea added a commit that referenced this pull request Nov 24, 2025
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Mar 6, 2026
* feat: add created/started/ended attribute to RowIterator.
* fix annotation
* links update
* mypy fix
* Update google/cloud/bigquery/query.py
Co-authored-by: Tim Sweña (Swast) <tswast@gmail.com>
* Update google/cloud/bigquery/table.py
Co-authored-by: Tim Sweña (Swast) <tswast@gmail.com>
* Update google/cloud/bigquery/table.py
Co-authored-by: Tim Sweña (Swast) <tswast@gmail.com>
* Update google/cloud/bigquery/query.py
Co-authored-by: Tim Sweña (Swast) <tswast@gmail.com>
* Update google/cloud/bigquery/query.py
Co-authored-by: Tim Sweña (Swast) <tswast@gmail.com>
* Update google/cloud/bigquery/job/query.py
Co-authored-by: Tim Sweña (Swast) <tswast@gmail.com>
* fix unit test
---------
Co-authored-by: Tim Sweña (Swast) <tswast@gmail.com>
Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: loggingIssues related to the Cloud Logging API.api: pubsubIssues related to the Pub/Sub API.cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver@daspecster@dhermes@googlebot