Uh oh!
There was an error while loading. Please reload this page.
fix README installation command and PyPI links - #2264
Conversation
it currently doesn't work
This reverts commit 76151e4.
current PyPI install command, links, and images point to the wrong package
googlebot
commented
Sep 8, 2016
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
ofek
commented
Sep 8, 2016
I've just signed the CLA. |
googlebot
commented
Sep 8, 2016
CLAs look good, thanks! |
dhermes
commented
Sep 8, 2016
Thanks for the PR but the change was intended. We are moving to |
ofek
commented
Sep 8, 2016
@dhermes Ah, I see. Shouldn't we wait to update install command/links since, as of now, they are incorrect? This may confuse the product's users, especially the error-producing |
dhermes
commented
Sep 8, 2016
Hopefully it will be transient, i.e. hopefully we have new versions ASAP |
tseaver
commented
Sep 8, 2016
We do need to publish a new version of the package Real Soon Now(TM). Likely a |
This is the first release after the rename. Closesgoogleapis#2264.
tseaver
commented
Sep 9, 2016
@Ofekmeister Thanks for the patch~ I am closing the PR without merging., because as soon as we can get a release out, the links as they stand now (without your patch) will be correct. |
daspecster
commented
Sep 13, 2016
| :: | ||
| $ pip install --upgrade google-cloud | ||
| $ pip install -U gcloud |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
dhermes
commented
Sep 13, 2016
@Ofekmeister This looks mostly fine other than my comment about leaving $ git checkout master # that is the name of your branch sent in this PR
$ git branch -m master master-old # Renames the local master branch
$ git fetch upstream # Make sure up to date
$ git branch master upstream/master # Adds a tracking branch for the project's master
$ git checkout master
$ git merge --squash master-old
$ git diff origin/master # Make sure the changes aren't too crazy.
$ git push --force origin master # This will overwrite the extra commits in this PR |
tseaver
commented
Sep 13, 2016
@dhermes For a change this tiny, we could just squash merge it in the Github UI: I don't think we care about exposing it in a changelog. |
dhermes
commented
Sep 13, 2016
@tseaver Good call. |
I believe I'm failing with git today. Can I just close this and open a new PR with all changes in one commit? edit: |
dhermes
commented
Sep 13, 2016
@Ofekmeister no worries, we can just use the GitHub squash merge feature on the PR. If you'd like to hone your |
ofek
commented
Sep 13, 2016
Yes, if you guys could please squash on your end that would be great. @dhermes Thanks for the offer! That would be enlightening :) Based on search results, I believe it is a Windows issue. |
tseaver
commented
Sep 13, 2016
I cancelled the Travis build, as this PR only affects the README. |
This is the first release after the rename. Closesgoogleapis#2264.
This is the first release after the rename. Closesgoogleapis#2264.
The current PyPI install command, links, and images point to the wrong package. I suppose this might be due to the new auto-generated documentation platform in use.