Skip to content

Support parsing DATE columns from Standard SQL tables - #2265

Merged
tseaver merged 1 commit into
googleapis:masterfrom
thejens:master
Sep 9, 2016
Merged

Support parsing DATE columns from Standard SQL tables#2265
tseaver merged 1 commit into
googleapis:masterfrom
thejens:master

Conversation

@thejens

@thejensthejens commented Sep 8, 2016

Copy link
Copy Markdown

Change-Id: I158b48b6470ff44ff006e18d5eb8e3540749670b

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 8, 2016
@thejens
thejensforce-pushed the master branch 2 times, most recently from 5ce1578 to dfdad0eCompareSeptember 8, 2016 11:56
@thejens

thejens commented Sep 8, 2016

Copy link
Copy Markdown
Author

... guess I couldn't quite figure out how to unit test the _date_from_json as I couldn't find where the other _X_from_json functions were tested

@tseaver

tseaver commented Sep 8, 2016

Copy link
Copy Markdown
Contributor

Tests for the bigquery._helpers module are here.

@tseaver

tseaver commented Sep 8, 2016

Copy link
Copy Markdown
Contributor

Thanks for the patch, BTW!

@thejens

thejens commented Sep 8, 2016

Copy link
Copy Markdown
Author

@tseaver Ty, I did find the tests module, but as the function I added had several similar functions I wanted to test it consistently, and I guess I couldn't find the tests for the others;

Ex. I added _date_from_json and "_float_from_json" already existed hence I want to test it in the same manner, but can't see where that happens

@tseaver

tseaver commented Sep 8, 2016

Copy link
Copy Markdown
Contributor

@thejens Hmmm, I see what you mean. Those helpers are being covered indirectly through the tests for query and table. They should probably have their own coverage in test__helpers.py, though.

@tseavertseaver mentioned this pull request Sep 8, 2016
Merged
@daspecsterdaspecster added the api: bigquery Issues related to the BigQuery API. label Sep 8, 2016
@tseaver

tseaver commented Sep 8, 2016

Copy link
Copy Markdown
Contributor

@thejens I landed more comprehensive tests for google.cloud.bigquery._helpers in #2272. They should serve as a model for your tests of _date_from_json.

Jens Larsson
Support parsing DATE columns from Standard SQL tables
3d8b6f4
Change-Id: I20a6fff4362e27ee35286a3538c24e37bc858faf
@thejens

thejens commented Sep 9, 2016

Copy link
Copy Markdown
Author

@tseaver Thanks for putting those tests there; seems they and the one I added passed

@tseaver
tseaver merged commit 298b28a into googleapis:masterSep 9, 2016
@tseaver

tseaver commented Sep 9, 2016

Copy link
Copy Markdown
Contributor

@thejens Thanks again!

@tseavertseaver mentioned this pull request Sep 19, 2016
Closed
@dhermesdhermes mentioned this pull request Sep 19, 2016
Merged
@tseavertseaver mentioned this pull request Sep 19, 2016
Closed
parthea added a commit that referenced this pull request Nov 24, 2025
@ohmayr@parthea
feat: add debug log when creating client (#2265)
9b9249a
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Mar 6, 2026
@tswast
chore: execute retry tests serially, since they depend on global time (…
1dfea75
…#2265)
* chore: migrate test_base retry tests
* migrate job_helpers test
* migrate more tests
* fix initiate resumable upload tests
* fix failing tests
* remove dead test code
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thejens@tseaver@daspecster@googlebot