Uh oh!
There was an error while loading. Please reload this page.
Widening the salience range for natural language system tests. - #2283
Merged
Conversation
Fixesgoogleapis#2274. However, the test will likely remain flaky if the output is a moving target.
tseaver
commented
Sep 9, 2016
Contributor
LGTM (but grrrrr). |
dhermes
commented
Sep 9, 2016
ContributorAuthor
I agree. I'm not sure what the value is of a service that gives non-deterministic results like that. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#2274. However, the test will likely remain flaky if the output is a moving target.