Skip to content

Vision text detection - #2299

Merged
daspecster merged 1 commit into
googleapis:masterfrom
daspecster:vision-text-detection
Sep 15, 2016
Merged

Vision text detection#2299
daspecster merged 1 commit into
googleapis:masterfrom
daspecster:vision-text-detection

Conversation

@daspecster

Copy link
Copy Markdown
Contributor

Based off #2237.

Adds text detection.

This is the last of the Entity based detections.

Safe Search and Image properties are left.

@daspecsterdaspecster added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: vision Issues related to the Cloud Vision API. labels Sep 12, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 12, 2016
@daspecster
daspecsterforce-pushed the vision-text-detection branch 2 times, most recently from deeb833 to 8b2e716CompareSeptember 12, 2016 21:57
Comment threaddocs/vision-usage.rst Outdated
>>> image = client.image('./image.jpg')
>>> text = image.detect_text()
>>> text.locale
>>> text[0].locale

This comment was marked as spam.

This comment was marked as spam.

@tseaver

Copy link
Copy Markdown
Contributor

LGTM: you can address my comments or leave them be, if you think best.

@daspecster

Copy link
Copy Markdown
ContributorAuthor

Ok, I updated the code based on your comments. I'll let travis run and then I'll make the next two PRs.

@daspecster
daspecster merged commit 51d11da into googleapis:masterSep 15, 2016
@dhermesdhermes mentioned this pull request Sep 19, 2016
@daspecster
daspecster deleted the vision-text-detection branch January 24, 2017 15:17
parthea pushed a commit that referenced this pull request Apr 1, 2026
This change aims to fix some string-related tests failing in #2248.
Fixes internal issue 417774347🦕
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: visionIssues related to the Cloud Vision API.cla: yesThis human has signed the Contributor License Agreement.do not mergeIndicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@daspecster@tseaver@googlebot