Skip to content

Vision image properties - #2320

Merged
daspecster merged 1 commit into
googleapis:masterfrom
daspecster:vision-image-properties
Sep 15, 2016
Merged

Vision image properties#2320
daspecster merged 1 commit into
googleapis:masterfrom
daspecster:vision-image-properties

Conversation

@daspecster

@daspecsterdaspecster commented Sep 15, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Based from #2319

Adds the image properties detection API for Vision.

This adds a fairly large ImagePropertiesAnnotation with several classes to absorb the color data in the response.

✅ Also after #2319 is merged I will clean up the weird commit history.

@daspecsterdaspecster added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: vision Issues related to the Cloud Vision API. labels Sep 15, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2016
@daspecster
daspecsterforce-pushed the vision-image-properties branch from a08bd4e to c741476CompareSeptember 15, 2016 02:38
@daspecsterdaspecster mentioned this pull request Sep 15, 2016
Merged
@daspecster
daspecsterforce-pushed the vision-image-properties branch 2 times, most recently from 71f4e4b to e99b0e2CompareSeptember 15, 2016 17:52
@daspecsterdaspecster removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 15, 2016
@daspecster

daspecster commented Sep 15, 2016

Copy link
Copy Markdown
ContributorAuthor

@tseaver, I cleaned this up so it should be ready to checkout as well.

@daspecster
daspecsterforce-pushed the vision-image-properties branch from e99b0e2 to acc96bcCompareSeptember 15, 2016 19:33
tseaver
tseaver reviewed Sep 15, 2016
View reviewed changes
Comment threadgoogle/cloud/vision/color.py Outdated

@property
def red(self):
"""Red color.

This comment was marked as spam.

Sign in to view

Comment threadgoogle/cloud/vision/color.py
return self._red

@property
def green(self):

This comment was marked as spam.

Sign in to view

Comment threadgoogle/cloud/vision/color.py
"""
return self._green

@property

This comment was marked as spam.

Sign in to view

Comment threadgoogle/cloud/vision/color.py Outdated

:type red: int
:param red: The amount of red in the color as a value in the interval
[0, 1].

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadgoogle/cloud/vision/color.py
:param color: RGB components of the color.

:type score: float
:param score: Image-specific score for this color. Value in range [0, 1].

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadunit_tests/vision/_fixtures.py Outdated
}
}
]
}

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@daspecster

daspecster commented Sep 15, 2016

Copy link
Copy Markdown
ContributorAuthor

@tseaver, updated everything except the score docstring. That value is copied from their docs, but I can't seem to find a better explanation of it.

@tseaver

tseaver commented Sep 15, 2016

Copy link
Copy Markdown
Contributor

LGTM

@daspecster
daspecsterforce-pushed the vision-image-properties branch from 5fdb9da to 5e0da90CompareSeptember 15, 2016 21:23
@daspecster
daspecster merged commit 0f5d982 into googleapis:masterSep 15, 2016
@dhermesdhermes mentioned this pull request Sep 19, 2016
Merged
@daspecster
daspecster deleted the vision-image-properties branch January 24, 2017 15:17
parthea pushed a commit that referenced this pull request Apr 1, 2026
@GarrettWu
feat: add fit_predict method to ml unsupervised models (#2320)
9a3301e
Thank you for opening a Pull Request! Before submitting your PR, there
are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a
[bug/issue](https://github.com/googleapis/python-bigquery-dataframes/issues/new/choose)
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
Fixes #<issue_number_goes_here> 🦕
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tseavertseavertseaver left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@tseavertseaver

Labels

api: visionIssues related to the Cloud Vision API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daspecster@tseaver@googlebot