Skip to content

Add 'QueryJob.results' method - #2321

Merged
tseaver merged 5 commits into
googleapis:masterfrom
tseaver:2083-bigquery-async_query_job-query_results
Sep 15, 2016
Merged

Add 'QueryJob.results' method#2321
tseaver merged 5 commits into
googleapis:masterfrom
tseaver:2083-bigquery-async_query_job-query_results

Conversation

@tseaver

@tseavertseaver commented Sep 15, 2016

Copy link
Copy Markdown
Contributor

@tseaver
Raise if 'query.run' is called after job is started.
fb31f5c
@tseaver
Add 'QueryResults.from_query_job' factory.
5c630fa
Construct the instance using the job's properties, and bind it to the job.
@tseaver
Move UDF-related stuff to '_helpers'.
9307d7e
@tseaver
Add 'QueryJob.results' factory.
4cd0aa4
Constructs a 'QueryResults' instance, bound to the job.
Closes#2083.
@tseavertseaver added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: bigquery Issues related to the BigQuery API. labels Sep 15, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2016
@daspecster

daspecster commented Sep 15, 2016

Copy link
Copy Markdown
Contributor

Should there be something in the bigquery-usage doc about this?

tswast
tswast reviewed Sep 15, 2016
View reviewed changes

@tswasttswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'll let someone more familiar with google-cloud-python approve.

Comment threadgoogle/cloud/bigquery/_helpers.py
raise ValueError('Pass one of: %s' ', '.join(self.ALLOWED))


class UDFResource(object):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadgoogle/cloud/bigquery/query.py
self._job = None

@classmethod
def from_query_job(cls, job):

This comment was marked as spam.

Sign in to view

daspecster
daspecster approved these changes Sep 15, 2016
View reviewed changes

@daspecsterdaspecster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending Travis

@tseaver
tseaver merged commit a92d69f into googleapis:masterSep 15, 2016
@tseaver
tseaver deleted the 2083-bigquery-async_query_job-query_results branch September 15, 2016 20:02
dhermes
dhermes reviewed Sep 16, 2016
View reviewed changes
Comment threadgoogle/cloud/bigquery/_helpers.py

class UDFResource(object):
"""Describe a single user-defined function (UDF) resource.
:type udf_type: str

This comment was marked as spam.

Sign in to view

@tseavertseaver mentioned this pull request Sep 16, 2016
Merged
@dhermesdhermes mentioned this pull request Sep 19, 2016
Merged
parthea added a commit that referenced this pull request Nov 24, 2025
@parthea
build: update all dependencies (#2321)
9cb386f
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswasttswasttswast left review comments
+2 more reviewers
@dhermesdhermesdhermes left review comments
@daspecsterdaspecsterdaspecster approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tseaver@daspecster@tswast@dhermes@googlebot